From: Thomas Huth <thuth@redhat.com>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: "Cleber Rosa" <crosa@redhat.com>, "John Snow" <jsnow@redhat.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
pbonzini@redhat.com, "David Hildenbrand" <david@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Eric Farman" <farman@linux.ibm.com>,
kraxel@redhat.com,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-s390x@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Beraldo Leal" <bleal@redhat.com>
Subject: Re: [PATCH 1/2] build-sys: fix crlf-ending C code
Date: Mon, 9 Jan 2023 12:41:20 +0100 [thread overview]
Message-ID: <0b04303a-20a6-d4fe-d9bc-0940e475d24b@redhat.com> (raw)
In-Reply-To: <20230109112110.128967-2-marcandre.lureau@redhat.com>
On 09/01/2023 12.21, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> On msys2, the shader-to-C script produces bad C:
> ./ui/shader/texture-blit-vert.h:2:5: error: missing terminating " character [-Werror]
>
> Fix it by changing the line ending from crlf to lf, and convert the
> script to Python (qemu build seems perl-free after that).
If the build process does not depend on Perl anymore, would it make sense to
also add a patch that removes perl from most of the containers (the ones
that don't use check_patch.pl etc.)? ... that way we would make sure that
the dependency does not creep in again later...
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> meson.build | 2 +-
> scripts/shaderinclude.pl | 16 ----------------
> scripts/shaderinclude.py | 22 ++++++++++++++++++++++
> 3 files changed, 23 insertions(+), 17 deletions(-)
> delete mode 100644 scripts/shaderinclude.pl
> create mode 100755 scripts/shaderinclude.py
Acked-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-01-09 11:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 11:21 [PATCH 0/2] Fix win32/msys2 shader compilation marcandre.lureau
2023-01-09 11:21 ` [PATCH 1/2] build-sys: fix crlf-ending C code marcandre.lureau
2023-01-09 11:41 ` Thomas Huth [this message]
2023-01-09 11:47 ` Marc-André Lureau
2023-01-09 15:56 ` Paolo Bonzini
2023-01-09 15:59 ` Marc-André Lureau
2023-01-09 12:20 ` Philippe Mathieu-Daudé
2023-01-09 11:21 ` [PATCH 2/2] .gitlab-ci.d/windows: do not disable opengl marcandre.lureau
2023-01-09 11:42 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b04303a-20a6-d4fe-d9bc-0940e475d24b@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=crosa@redhat.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).