From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6222C43334 for ; Mon, 4 Jul 2022 14:41:59 +0000 (UTC) Received: from localhost ([::1]:48296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8NGw-00047W-S3 for qemu-devel@archiver.kernel.org; Mon, 04 Jul 2022 10:41:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45252) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8Mgs-0007ur-Uw for qemu-devel@nongnu.org; Mon, 04 Jul 2022 10:04:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:48081) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8Mgp-0001an-FJ for qemu-devel@nongnu.org; Mon, 04 Jul 2022 10:04:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656943478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3YJBIQ3KZS2kosDWmEX4LYFVVC9WYJNZL4/cJiH+J70=; b=OwdfbKzy6qal4eYOfSoqVooYFvluX4j9N8N7ahOkDA4myopgQni/DSX60bQumph7AMA1Ah 8wzJnbwSWPcJVuAUbc6ZBIDRBLWpUOORQR9/V7KQgeUDVCWIjyKSPugqxBvg6abVeZzdIV 0uxd0T8fnV/3hI8Y9F+8NOFQ9Z7Nfyg= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-517-Xtma31MYM3epKVy-edd5wg-1; Mon, 04 Jul 2022 10:04:37 -0400 X-MC-Unique: Xtma31MYM3epKVy-edd5wg-1 Received: by mail-ej1-f71.google.com with SMTP id z7-20020a170906434700b007108b59c212so2067015ejm.5 for ; Mon, 04 Jul 2022 07:04:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=3YJBIQ3KZS2kosDWmEX4LYFVVC9WYJNZL4/cJiH+J70=; b=WznQm9DRB2OJMgGT98WqZzYNRheHOm8chZhb/ThmoPLSBPhuIXFF6E20k5y1s/cmwn Lo1ZzOA0XNdY2IXmz7lX65hGVGFmtocE4ykzPHAP5swp9fU46uUapsx58J+gv1yiQgiV +5P0SrrrTy/yUKQ0uAv3NzJ+QArMe03JSo/b8AIR3R5LR4ojNHJ4G6A3M9ZfiRYZNUkK IYWoUBBn6hQRMqrtGhaDes7ujTeicdC3aux58bajbWvVOHyOJ8tcV2lkrc/lO5bsI3qf FSBvB9qd74wF9HS29vAKUmig7fsE+y1OCZ4pgXJBCC2XRpr0Hqfx9cly1hpKuXV4EtvI OWgw== X-Gm-Message-State: AJIora/O4RLLuYDJ/2bvJLxrlIJR1TOpv16ev6bznS69MFJrVL6+APH9 V5d1TVAvllgmwu3WeLo1CRObYKlDSgCb/6BGl6rqeYuKp+zM6Nq1EJZADwBdqYexRQUby3QqSVp X9/W2M1488Lhoui8= X-Received: by 2002:a17:906:938a:b0:726:942a:54ef with SMTP id l10-20020a170906938a00b00726942a54efmr29203730ejx.728.1656943476272; Mon, 04 Jul 2022 07:04:36 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s/GicAGvTpiV3kjhcv7yJDeUvdhmBy9WtOyWECzw09/mIgOpvVkDxMpJOuV5cIGetTnBeqgA== X-Received: by 2002:a17:906:938a:b0:726:942a:54ef with SMTP id l10-20020a170906938a00b00726942a54efmr29203661ejx.728.1656943475852; Mon, 04 Jul 2022 07:04:35 -0700 (PDT) Received: from ?IPV6:2a02:8071:5056:d40:63e3:25a7:c1a1:4455? ([2a02:8071:5056:d40:63e3:25a7:c1a1:4455]) by smtp.gmail.com with ESMTPSA id m18-20020a056402051200b0043a61f6c389sm1726951edv.4.2022.07.04.07.04.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Jul 2022 07:04:35 -0700 (PDT) Message-ID: <0b04e477-75ec-cf8d-04b0-e6c6653504ea@redhat.com> Date: Mon, 4 Jul 2022 16:04:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 02/18] block: Add a 'flags' param to blk_pread() Content-Language: en-US To: Alberto Faria , qemu-devel@nongnu.org Cc: Andrew Jeffery , Peter Maydell , qemu-block@nongnu.org, Palmer Dabbelt , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-ppc@nongnu.org, Eric Blake , Vladimir Sementsov-Ogievskiy , John Snow , Stefan Hajnoczi , Jeff Cody , qemu-riscv@nongnu.org, =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Joel Stanley , Stefan Weil , Laurent Vivier , "Denis V. Lunev" , Juan Quintela , "Dr. David Alan Gilbert" , Niek Linnenbank , Greg Kurz , Daniel Henrique Barboza , Kevin Wolf , "Edgar E. Iglesias" , qemu-arm@nongnu.org, Fam Zheng , Alistair Francis , Beniamino Galvani , Bin Meng , David Gibson References: <20220517113524.197910-1-afaria@redhat.com> <20220517113524.197910-3-afaria@redhat.com> From: Hanna Reitz In-Reply-To: <20220517113524.197910-3-afaria@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=hreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 17.05.22 13:35, Alberto Faria wrote: > For consistency with other I/O functions, and in preparation to > implement it using generated_co_wrapper. > > Callers were updated using this Coccinelle script: > > @@ expression blk, offset, buf, bytes; @@ > - blk_pread(blk, offset, buf, bytes) > + blk_pread(blk, offset, buf, bytes, 0) > > It had no effect on hw/block/nand.c, presumably due to the #if, so that > file was updated manually. > > Overly-long lines were then fixed by hand. > > Signed-off-by: Alberto Faria > --- > block.c | 2 +- > block/block-backend.c | 5 +++-- > block/commit.c | 2 +- > block/export/fuse.c | 2 +- > hw/arm/allwinner-h3.c | 2 +- > hw/arm/aspeed.c | 2 +- > hw/block/block.c | 2 +- > hw/block/fdc.c | 6 +++--- > hw/block/hd-geometry.c | 2 +- > hw/block/m25p80.c | 2 +- > hw/block/nand.c | 12 ++++++------ > hw/block/onenand.c | 12 ++++++------ > hw/ide/atapi.c | 4 ++-- > hw/misc/mac_via.c | 2 +- > hw/misc/sifive_u_otp.c | 4 ++-- > hw/nvram/eeprom_at24c.c | 2 +- > hw/nvram/spapr_nvram.c | 2 +- > hw/nvram/xlnx-bbram.c | 2 +- > hw/nvram/xlnx-efuse.c | 2 +- > hw/ppc/pnv_pnor.c | 2 +- > hw/sd/sd.c | 2 +- > include/sysemu/block-backend-io.h | 3 ++- > migration/block.c | 4 ++-- > nbd/server.c | 4 ++-- > qemu-img.c | 12 ++++++------ > qemu-io-cmds.c | 2 +- > tests/unit/test-block-iothread.c | 4 ++-- > 27 files changed, 52 insertions(+), 50 deletions(-) Reviewed-by: Hanna Reitz