* Re: [PATCH] hw/avr: Realize AVRCPU qdev object using qdev_realize()
2021-12-05 22:41 [PATCH] hw/avr: Realize AVRCPU qdev object using qdev_realize() Philippe Mathieu-Daudé
@ 2021-12-06 8:49 ` Michael Rolnik
2021-12-15 10:25 ` Philippe Mathieu-Daudé
2021-12-17 9:43 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Michael Rolnik @ 2021-12-06 8:49 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Eduardo Habkost, qemu-trivial, qemu-devel, Markus Armbruster
[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]
Reviewed-by: Michael Rolnik <mrolnik@gmail.com>
On Mon, Dec 6, 2021 at 12:41 AM Philippe Mathieu-Daudé <f4bug@amsat.org>
wrote:
> TYPE_AVR_CPU inherits TYPE_CPU, which itself inherits TYPE_DEVICE.
> TYPE_DEVICE instances are realized using qdev_realize(), we don't
> need to access QOM internal values.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/avr/atmega.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/avr/atmega.c b/hw/avr/atmega.c
> index 0608e2d475e..a34803e6427 100644
> --- a/hw/avr/atmega.c
> +++ b/hw/avr/atmega.c
> @@ -233,7 +233,7 @@ static void atmega_realize(DeviceState *dev, Error
> **errp)
>
> /* CPU */
> object_initialize_child(OBJECT(dev), "cpu", &s->cpu, mc->cpu_type);
> - object_property_set_bool(OBJECT(&s->cpu), "realized", true,
> &error_abort);
> + qdev_realize(DEVICE(&s->cpu), NULL, &error_abort);
> cpudev = DEVICE(&s->cpu);
>
> /* SRAM */
> --
> 2.33.1
>
>
--
Best Regards,
Michael Rolnik
[-- Attachment #2: Type: text/html, Size: 1626 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/avr: Realize AVRCPU qdev object using qdev_realize()
2021-12-05 22:41 [PATCH] hw/avr: Realize AVRCPU qdev object using qdev_realize() Philippe Mathieu-Daudé
2021-12-06 8:49 ` Michael Rolnik
@ 2021-12-15 10:25 ` Philippe Mathieu-Daudé
2021-12-17 9:43 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-12-15 10:25 UTC (permalink / raw)
To: qemu-devel
Cc: Eduardo Habkost, qemu-trivial, Michael Rolnik, Markus Armbruster
Hi Laurent,
This patch is reviewed, can it go via your trivial tree?
On 12/5/21 23:41, Philippe Mathieu-Daudé wrote:
> TYPE_AVR_CPU inherits TYPE_CPU, which itself inherits TYPE_DEVICE.
> TYPE_DEVICE instances are realized using qdev_realize(), we don't
> need to access QOM internal values.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/avr/atmega.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/avr/atmega.c b/hw/avr/atmega.c
> index 0608e2d475e..a34803e6427 100644
> --- a/hw/avr/atmega.c
> +++ b/hw/avr/atmega.c
> @@ -233,7 +233,7 @@ static void atmega_realize(DeviceState *dev, Error **errp)
>
> /* CPU */
> object_initialize_child(OBJECT(dev), "cpu", &s->cpu, mc->cpu_type);
> - object_property_set_bool(OBJECT(&s->cpu), "realized", true, &error_abort);
> + qdev_realize(DEVICE(&s->cpu), NULL, &error_abort);
> cpudev = DEVICE(&s->cpu);
>
> /* SRAM */
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/avr: Realize AVRCPU qdev object using qdev_realize()
2021-12-05 22:41 [PATCH] hw/avr: Realize AVRCPU qdev object using qdev_realize() Philippe Mathieu-Daudé
2021-12-06 8:49 ` Michael Rolnik
2021-12-15 10:25 ` Philippe Mathieu-Daudé
@ 2021-12-17 9:43 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2021-12-17 9:43 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Eduardo Habkost, qemu-trivial, Michael Rolnik, Markus Armbruster
Le 05/12/2021 à 23:41, Philippe Mathieu-Daudé a écrit :
> TYPE_AVR_CPU inherits TYPE_CPU, which itself inherits TYPE_DEVICE.
> TYPE_DEVICE instances are realized using qdev_realize(), we don't
> need to access QOM internal values.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/avr/atmega.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/avr/atmega.c b/hw/avr/atmega.c
> index 0608e2d475e..a34803e6427 100644
> --- a/hw/avr/atmega.c
> +++ b/hw/avr/atmega.c
> @@ -233,7 +233,7 @@ static void atmega_realize(DeviceState *dev, Error **errp)
>
> /* CPU */
> object_initialize_child(OBJECT(dev), "cpu", &s->cpu, mc->cpu_type);
> - object_property_set_bool(OBJECT(&s->cpu), "realized", true, &error_abort);
> + qdev_realize(DEVICE(&s->cpu), NULL, &error_abort);
> cpudev = DEVICE(&s->cpu);
>
> /* SRAM */
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread