Re: [PATCH v4 08/12] hw/ppc/pegasos2: Move hardware specific parts out of machine reset

[Harsh Prateek Bora <harshpb@linux.ibm.com>]

On 10/23/25 12:16, Philippe Mathieu-Daudé wrote:
> On 23/10/25 02:06, BALATON Zoltan wrote:
>> Move the pegasos2 specific chipset reset out from machine reset to a
>> separate function and move generic parts that are not pegasos2
>> specific from build_fdt to machine reset so now build_fdt only
>> contains pegasos2 specific parts and can be renamed accordingly.
>>
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>> ---
>>   hw/ppc/pegasos2.c | 79 ++++++++++++++++++++++++-----------------------
>>   1 file changed, 41 insertions(+), 38 deletions(-)
> 
> 
>> -#define PCI1_IO_BASE  0xfe000000
> 
> Can't we keep such definition?
> 
>> @@ -308,23 +307,12 @@ static void 
>> pegasos2_pci_config_write(Pegasos2MachineState *pm, int bus,
>>   static void pegasos2_superio_write(uint8_t addr, uint8_t val)
>>   {
>> -    cpu_physical_memory_write(PCI1_IO_BASE + 0x3f0, &addr, 1);
>> -    cpu_physical_memory_write(PCI1_IO_BASE + 0x3f1, &val, 1);
>> +    cpu_physical_memory_write(0xfe0003f0, &addr, 1);
>> +    cpu_physical_memory_write(0xfe0003f1, &val, 1);
> 
> Otherwise it is harder to notice we are accessing the MMIO mapped ISA 
> space.
> 
>>   }
> Consider renaming as pegasos_superio_write() since this method becomes
> common to PegasOS I and II.

Thanks Philippe for reviewing the series.

Hi BALATON,
Would you mind addressing the above (and other?) review comments or I 
can queue it in the interest of time if you can send a follow-up patch 
later?

Thanks
Harsh

> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>