From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D76D0C4361B for ; Tue, 15 Dec 2020 23:29:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B70F22CAE for ; Tue, 15 Dec 2020 23:29:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B70F22CAE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54614 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpJkx-00060A-U6 for qemu-devel@archiver.kernel.org; Tue, 15 Dec 2020 18:29:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpJeK-0004qO-94 for qemu-devel@nongnu.org; Tue, 15 Dec 2020 18:22:32 -0500 Received: from mail-oo1-xc41.google.com ([2607:f8b0:4864:20::c41]:39604) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kpJeI-0008LV-Li for qemu-devel@nongnu.org; Tue, 15 Dec 2020 18:22:31 -0500 Received: by mail-oo1-xc41.google.com with SMTP id k9so5267977oop.6 for ; Tue, 15 Dec 2020 15:22:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gAOqAEKgtDopVLswWnS4lG+9el5eIJssgOsRmeRbIUo=; b=MH2g5td4pqDww5l3EfNzZam2wJKmfUwjFNymXpkJbZGRAH/uH/ykE5xdFjo8mXnAgU PjhLcg6AsOVZBEnformDG73U4YwV96p2uafYeZ7KCmb291lNH18J1fKgoRq0CVc7sqtS yaS/MEcKO/0rDGIaDmJRxFr0Ji24h5wCXgx6OysuEaIT2dMNoGPWQHZJ3Rn7JlbUPbqV bk3Tl8gYwqeTfo/h322eW/RXYc8LZrbgJ1I1WX1A9S7PpyPhHJ/FNnnFW4/5SMD5rBKF OBosLg3R64DWSMGklX9ZRgkY1BsaGiQTiqi8vNbyJxGGM4miEm8JUq9vvG7yP4sVY8ni 75FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gAOqAEKgtDopVLswWnS4lG+9el5eIJssgOsRmeRbIUo=; b=q6DDANfbJi7etIBySkKzBQqhcvuwpaGur8eqskgiMYaLbMiNWUc5wWrJ4EmTxKsaUu IgeI6bN00geFoJ+AUgIGHlNyxm6J9/hK9QJr5NKavqyICOA5GBjgTdUjyKHh9draMj/y Ui0StmGIoGV2ii+ybVIKAYJeA2N528A52DGe75A3y+eqTraMmH+N+ukUBihqdr+W2z2C DClW7XxaY1kKeLs3/FT4kjzrD3PUfZ3GBiutmAxOv5aJ9PbAZ2TI8w9++DB4vWCnqPWT rBxVLus2gLcHtjsoC3PF4mFhcQG47AXLa58IbC4cIhUEbqqf8P1OB+rM4BKUAMaC7MPu GZcg== X-Gm-Message-State: AOAM531e0Dx0tgsy6dIqTsnqlQBk7OOC6pdJQ9MubyxiIUoJox7LgbVg S0E4VdHGwAzYL+zxXGKq5rSScw== X-Google-Smtp-Source: ABdhPJyYb7BtNjIKViVJ3fa6Upa+QE4PTCFJtpOOi4c3nagi9JwrLGx0peUqXw4dYgEeA1nWZkEH7A== X-Received: by 2002:a4a:c387:: with SMTP id u7mr19133338oop.89.1608074549489; Tue, 15 Dec 2020 15:22:29 -0800 (PST) Received: from [10.10.121.52] (fixed-187-189-51-144.totalplay.net. [187.189.51.144]) by smtp.gmail.com with ESMTPSA id v92sm91767otb.75.2020.12.15.15.22.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Dec 2020 15:22:28 -0800 (PST) Subject: Re: [RFC PATCH v2 24/24] target/mips/mod-msa: Pass TCGCond argument to gen_check_zero_element() To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20201215225757.764263-1-f4bug@amsat.org> <20201215225757.764263-25-f4bug@amsat.org> From: Richard Henderson Message-ID: <0b151ab5-edb4-3cec-4c94-7f7dff43738c@linaro.org> Date: Tue, 15 Dec 2020 17:22:26 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201215225757.764263-25-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::c41; envelope-from=richard.henderson@linaro.org; helo=mail-oo1-xc41.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , kvm@vger.kernel.org, Huacai Chen , Jiaxun Yang , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/15/20 4:57 PM, Philippe Mathieu-Daudé wrote: > Simplify gen_check_zero_element() by passing the TCGCond > argument along. > > Suggested-by: Richard Henderson > Signed-off-by: Philippe Mathieu-Daudé > --- > Maybe this can be named 'msa_translate.c' after all... > --- > target/mips/mod-msa_translate.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) Reviewed-by: Richard Henderson r~