From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e021I-0005rN-Of for qemu-devel@nongnu.org; Thu, 05 Oct 2017 05:00:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0218-0000nM-Nh for qemu-devel@nongnu.org; Thu, 05 Oct 2017 05:00:40 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:45940) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e0218-0000m3-9A for qemu-devel@nongnu.org; Thu, 05 Oct 2017 05:00:30 -0400 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v958xCKY021030 for ; Thu, 5 Oct 2017 05:00:25 -0400 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ddf96pwdq-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 05 Oct 2017 05:00:21 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 5 Oct 2017 10:00:19 +0100 References: <1507193105-15627-1-git-send-email-thuth@redhat.com> From: Halil Pasic Date: Thu, 5 Oct 2017 11:00:14 +0200 MIME-Version: 1.0 In-Reply-To: <1507193105-15627-1-git-send-email-thuth@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: <0b169349-658d-3f65-85d6-6957f082df1b@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH] hw/s390x: Mark the "sclpquiesce" device with user_creatable = false List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org, Cornelia Huck , Christian Borntraeger Cc: Eric Farman , Janosch Frank , Yi Min Zhao , Jason J Herne , David Hildenbrand , Pierre Morel , Farhan Ali , Jing Liu , Claudio Imbrenda , QingFeng Hao , Xiao Feng Ren , Fei Li , Dong Jia Shi , Yang Chen On 10/05/2017 10:45 AM, Thomas Huth wrote: > The "sclpquiesce" device is just an internal device that should not be > created by the user directly. Though it currently does not seem to cause > any obvious trouble when the user instantiates an additional device, let's > better mark it with user_creatable = false to avoid unexpected behavior, > e.g. because the quiesce notifier gets registered multiple times. > > Signed-off-by: Thomas Huth Reviewed-by: Halil Pasic > --- > hw/s390x/sclpquiesce.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/hw/s390x/sclpquiesce.c b/hw/s390x/sclpquiesce.c > index 762cb18..0241643 100644 > --- a/hw/s390x/sclpquiesce.c > +++ b/hw/s390x/sclpquiesce.c > @@ -118,8 +118,13 @@ static void quiesce_class_init(ObjectClass *klass, void *data) > dc->reset = quiesce_reset; > dc->vmsd = &vmstate_sclpquiesce; > set_bit(DEVICE_CATEGORY_MISC, dc->categories); > - k->init = quiesce_init; > + /* > + * Reason: This is just an internal device - the notifier should > + * not be registered multiple times in quiesce_init() > + */ > + dc->user_creatable = false; > > + k->init = quiesce_init; > k->get_send_mask = send_mask; > k->get_receive_mask = receive_mask; > k->can_handle_event = can_handle_event; >