From: Richard Henderson <richard.henderson@linaro.org>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 1/4] qemu-common: Move tcg_enabled() etc. to sysemu/tcg.h
Date: Thu, 23 May 2019 14:38:41 -0400 [thread overview]
Message-ID: <0b1f943b-b8c6-5b1d-7a40-bc1db86d8ccf@linaro.org> (raw)
In-Reply-To: <20190523143508.25387-2-armbru@redhat.com>
On 5/23/19 10:35 AM, Markus Armbruster wrote:
> Other accelerators have their own headers: sysemu/hax.h, sysemu/hvf.h,
> sysemu/kvm.h, sysemu/whpx.h. Only tcg_enabled() & friends sit in
> qemu-common.h. This necessitates inclusion of qemu-common.h into
> headers, which is against the rules spelled out in qemu-common.h's
> file comment.
>
> Move tcg_enabled() & friends into their own header sysemu/tcg.h, and
> adjust #include directives.
>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2019-05-23 18:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 14:35 [Qemu-devel] [PATCH 0/4] Cleanups around qemu-common.h Markus Armbruster
2019-05-23 14:35 ` [Qemu-devel] [PATCH 1/4] qemu-common: Move tcg_enabled() etc. to sysemu/tcg.h Markus Armbruster
2019-05-23 18:38 ` Richard Henderson [this message]
2019-05-23 14:35 ` [Qemu-devel] [PATCH 2/4] qemu-common: Move qemu_isalnum() etc. to qemu/ctype.h Markus Armbruster
2019-05-23 18:39 ` Richard Henderson
2019-05-23 14:35 ` [Qemu-devel] [PATCH 3/4] Include qemu/module.h where needed, drop it from qemu-common.h Markus Armbruster
2019-05-23 14:35 ` [Qemu-devel] [PATCH 4/4] Include qemu-common.h exactly where needed Markus Armbruster
2019-06-07 15:21 ` [Qemu-devel] [PATCH 0/4] Cleanups around qemu-common.h Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b1f943b-b8c6-5b1d-7a40-bc1db86d8ccf@linaro.org \
--to=richard.henderson@linaro.org \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).