From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Michael Roth <michael.roth@amd.com>,
Riku Voipio <riku.voipio@iki.fi>,
Christian Schoenebeck <qemu_oss@crudebyte.com>,
Yanan Wang <wangyanan55@huawei.com>, Greg Kurz <groug@kaod.org>,
Richard Henderson <richard.henderson@linaro.org>,
Kyle Evans <kevans@freebsd.org>,
Eduardo Habkost <eduardo@habkost.net>,
Stefan Hajnoczi <stefanha@redhat.com>,
Eric Blake <eblake@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Warner Losh <imp@bsdimp.com>, Paolo Bonzini <pbonzini@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Subject: Re: [PATCH 02/10] trace-events: remove the remaining vcpu trace events
Date: Fri, 21 Apr 2023 08:47:39 +0200 [thread overview]
Message-ID: <0b23a90f-c6d3-2ce0-2bf8-9e9f199257b6@linaro.org> (raw)
In-Reply-To: <20230420150009.1675181-3-alex.bennee@linaro.org>
On 20/4/23 17:00, Alex Bennée wrote:
> While these are all in helper functions being designated vcpu events
> complicates the removal of the dynamic vcpu state code. TCG plugins
> allow you to instrument vcpu_[init|exit|idle].
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> hw/core/cpu-common.c | 2 --
> trace/control-target.c | 1 -
> trace/control.c | 2 --
> trace-events | 31 -------------------------------
> 4 files changed, 36 deletions(-)
>
> diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c
> index 5ccc3837b6..8373a500d2 100644
> --- a/hw/core/cpu-common.c
> +++ b/hw/core/cpu-common.c
> @@ -112,8 +112,6 @@ void cpu_dump_state(CPUState *cpu, FILE *f, int flags)
> void cpu_reset(CPUState *cpu)
> {
> device_cold_reset(DEVICE(cpu));
> -
> - trace_guest_cpu_reset(cpu);
> }
Can we convert this one to a "normal" trace event instead of
removing it? I find it helpful in build configured without plugin.
next prev parent reply other threads:[~2023-04-21 6:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 14:59 [PATCH 00/10] tracing: remove dynamic vcpu state Alex Bennée
2023-04-20 15:00 ` [PATCH 01/10] *-user: remove the guest_user_syscall tracepoints Alex Bennée
2023-04-20 15:29 ` Warner Losh
2023-04-20 15:00 ` [PATCH 02/10] trace-events: remove the remaining vcpu trace events Alex Bennée
2023-04-21 6:47 ` Philippe Mathieu-Daudé [this message]
2023-04-20 15:00 ` [PATCH 03/10] trace: remove vcpu_id from the TraceEvent structure Alex Bennée
2023-04-21 6:50 ` Philippe Mathieu-Daudé
2023-04-20 15:00 ` [PATCH 04/10] scripts/qapi: document the tool that generated the file Alex Bennée
2023-04-20 15:00 ` [PATCH 05/10] qapi: make the vcpu parameters deprecated for 8.1 Alex Bennée
2023-04-20 15:00 ` [PATCH 06/10] trace: remove code that depends on setting vcpu Alex Bennée
2023-04-20 15:00 ` [PATCH 07/10] trace: remove control-vcpu.h Alex Bennée
2023-04-21 6:50 ` Philippe Mathieu-Daudé
2023-04-20 15:00 ` [PATCH 08/10] tcg: remove the final vestiges of dstate Alex Bennée
2023-04-20 15:00 ` [PATCH 09/10] hw/9pfs: use qemu_xxhash4 Alex Bennée
2023-04-20 15:35 ` Christian Schoenebeck
2023-04-21 6:51 ` Philippe Mathieu-Daudé
2023-04-20 15:00 ` [PATCH 10/10] xxhash: remove qemu_xxhash7 Alex Bennée
2023-04-21 6:53 ` Philippe Mathieu-Daudé
2023-05-01 20:25 ` [PATCH 00/10] tracing: remove dynamic vcpu state Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b23a90f-c6d3-2ce0-2bf8-9e9f199257b6@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=groug@kaod.org \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=richard.henderson@linaro.org \
--cc=riku.voipio@iki.fi \
--cc=stefanha@redhat.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).