From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] build: use "meson test" as the test harness
Date: Sun, 31 Oct 2021 22:04:58 +0100 [thread overview]
Message-ID: <0b3d0211-1bcf-b033-2f15-efcd85bb78aa@redhat.com> (raw)
In-Reply-To: <60e3154f-16a2-98d9-ec29-e4c6a2291c20@redhat.com>
On 28/10/21 20:03, Thomas Huth wrote:
> Thanks for the update, this works definitely better than the RFC
> already. However, I spotted another oddity: "make check-softfloat" now
> is way slower than before, it takes more than 2 minutes now, while it
> finished within 20 seconds before your change ...
Hmm, so it does. "make check" and "make check SPEED=slow" work as
intended, but "make check-softfloat" includes the slow tests.
What happens is that "make check-softfloat" uses the setup that excludes
slow tests, but specifying "--suite softfloat" force-includes them
again. It makes sense, but in order to keep the same behavior I'll have
to come up with a different handling of $(SPEED). Thanks for the test!
Paolo
prev parent reply other threads:[~2021-10-31 21:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 14:28 [PATCH 0/2] Replace custom test harness with "meson test" Paolo Bonzini
2021-10-28 14:28 ` [PATCH 1/2] meson: bump submodule to 0.59.3 Paolo Bonzini
2021-10-28 16:05 ` Thomas Huth
2021-10-28 14:28 ` [PATCH 2/2] build: use "meson test" as the test harness Paolo Bonzini
2021-10-28 18:03 ` Thomas Huth
2021-10-31 21:04 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b3d0211-1bcf-b033-2f15-efcd85bb78aa@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).