From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org
Subject: Re: [PATCH v4.5 27/29] gdbstub: Adjust gdb_do_syscall to only use uint32_t and uint64_t
Date: Fri, 3 Mar 2023 10:44:49 +0100 [thread overview]
Message-ID: <0b3f38db-81c5-6114-28d4-69aeafae3d34@linaro.org> (raw)
In-Reply-To: <20230303025805.625589-28-richard.henderson@linaro.org>
On 3/3/23 03:58, Richard Henderson wrote:
> Pass %x as uint32_t and %lx as uint64_t; pass the address
> of %s as uint64_t and the length as uint32_t.
>
> Add casts in semihosting/syscalls.c from target_ulong to
> uint64_t; add casts from int to uint32_t for clarity.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> gdbstub/syscalls.c | 12 ++++++------
> semihosting/syscalls.c | 34 ++++++++++++++++++++--------------
> 2 files changed, 26 insertions(+), 20 deletions(-)
Few more casts, but nice target(_ulong) simplification!
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-03-03 9:45 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 2:57 [PATCH v4.5 00/29] gdbstub/next: re-organise and split build Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 01/29] gdbstub/internals.h: clean up include guard Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 02/29] gdbstub: fix-up copyright and license files Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 03/29] gdbstub: Make syscall_complete/[gs]et_reg target-agnostic typedefs Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 04/29] gdbstub: clean-up indent on gdb_exit Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 05/29] gdbstub: define separate user/system structures Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 06/29] gdbstub: move GDBState to shared internals header Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 07/29] includes: move tb_flush into its own header Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 08/29] gdbstub: move fromhex/tohex routines to internals Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 09/29] gdbstub: make various helpers visible to the rest of the module Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 10/29] gdbstub: move chunk of softmmu functionality to own file Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 11/29] gdbstub: move chunks of user code into own files Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 12/29] gdbstub: rationalise signal mapping in softmmu Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 13/29] gdbstub: abstract target specific details from gdb_put_packet_binary Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 14/29] gdbstub: specialise handle_query_attached Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 15/29] gdbstub: specialise target_memory_rw_debug Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 16/29] gdbstub: introduce gdb_get_max_cpus Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 17/29] gdbstub: specialise stub_can_reverse Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 18/29] gdbstub: fix address type of gdb_set_cpu_pc Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 19/29] gdbstub: don't use target_ulong while handling registers Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 20/29] gdbstub: move register helpers into standalone include Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 21/29] gdbstub: move syscall handling to new file Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 22/29] gdbstub: only compile gdbstub twice for whole build Richard Henderson
2023-03-03 2:57 ` [PATCH v4.5 23/29] testing: probe gdb for supported architectures ahead of time Richard Henderson
2023-03-03 2:58 ` [PATCH v4.5 24/29] include: split target_long definition from cpu-defs Richard Henderson
2023-03-03 2:58 ` [PATCH v4.5 25/29] gdbstub: split out softmmu/user specifics for syscall handling Richard Henderson
2023-03-03 2:58 ` [PATCH v4.5 26/29] gdbstub: Remove gdb_do_syscallv Richard Henderson
2023-03-03 9:43 ` Philippe Mathieu-Daudé
2023-03-03 2:58 ` [PATCH v4.5 27/29] gdbstub: Adjust gdb_do_syscall to only use uint32_t and uint64_t Richard Henderson
2023-03-03 9:44 ` Philippe Mathieu-Daudé [this message]
2023-03-03 2:58 ` [PATCH v4.5 28/29] gdbstub: Build syscall.c once Richard Henderson
2023-03-03 9:45 ` Philippe Mathieu-Daudé
2023-03-03 2:58 ` [PATCH v4.5 29/29] gdbstub: move update guest debug to accel ops Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b3f38db-81c5-6114-28d4-69aeafae3d34@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).