From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02CA3CAC5B0 for ; Thu, 2 Oct 2025 08:33:24 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v4Ej0-0001Bi-6P; Thu, 02 Oct 2025 04:31:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v4Eix-00019o-Hk for qemu-devel@nongnu.org; Thu, 02 Oct 2025 04:31:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v4Eid-0003sH-AJ for qemu-devel@nongnu.org; Thu, 02 Oct 2025 04:31:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759393866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CiQeq7LBJMi00PqpAzdN+6dUnE4tov5qZ2FmmHPUbAI=; b=Bf2n1q0hhyTykfHHLcXBe9IEjPwMcbGjP5s0KH6pM1Pd2i8E/oV7cHpVDlCpISlDSt0vFx MdzmhGFec+WnuerrIEgOWa+E4g3GgCG0ckqpSlIFXE279DW4aZo7YSSFuEcxJQqFooens4 molqFSnV/Z7tp1k1Nz6QcyQlJp0Bs3c= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-416-m49Wd7AsMwioimAcGpf3Xw-1; Thu, 02 Oct 2025 04:31:05 -0400 X-MC-Unique: m49Wd7AsMwioimAcGpf3Xw-1 X-Mimecast-MFC-AGG-ID: m49Wd7AsMwioimAcGpf3Xw_1759393864 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3ee12ab7f33so592690f8f.2 for ; Thu, 02 Oct 2025 01:31:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759393864; x=1759998664; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CiQeq7LBJMi00PqpAzdN+6dUnE4tov5qZ2FmmHPUbAI=; b=Pi4qXnqz53Dvq+Su19jgrqVoERacwNSh/fd73M34BpbiKv4ZgZixu7AG1YQIwbAssG m1KEbR93cMxs9XbHXcEb/VSQfDkYU4z0xArSvAkBRkIh+Szz1crA2V5JLEP5j/PBiusN rU8HW5UUhHxVhxtXTAEbqAzF11NI9O47I8zgdnFGBJZ+V6MRA6k1E/osI9f9tpyQyMUk +P9aleKC7FOcqlYTVXY4kO9ItGiFCsPjqpQaN68gQDzlJf5nud/V06XBdyXcgYEo7/k1 v2lG8DrYslhOaOm15bTS3o69xTvuabxBdaw1w784HVnQudqNyXlQmRvcOhy1NMTIU7Lm 58fA== X-Forwarded-Encrypted: i=1; AJvYcCUP9YsOsedlLUhd98qsldoNC2E2FJhHjpTpKThzIGverWjCt0DbWYJqM08HTxkzGUm6Xzjflpxd6bEK@nongnu.org X-Gm-Message-State: AOJu0Yy7PeHISr4ktu0lrpkZ+vHQapRFS6gmI0149ffrIWViPYFM4y8g A5jBD9lNHnZNQAlDCyNpkZXIYWAbkVIyss91vPQoJkCI5KGPNN6baqCzlOUr3Kv3hra4K80afRG Nc447YzdMUIEq4dlXQFZ/mbToHJNqOWtVSLsL+/pXZ3LKZGn4A3y+GUue X-Gm-Gg: ASbGncu/PKvhlfvdoaufNwJgn/sVk9zX3625bqoispPDrNHfKLveylCSL1vEM6NlNwF wOhm4IXf5BQ5R+6uMhMzV4IQJUsC0UXmIQl+bXwEIP/f1RrgV34xy05JvyYE6sI7J3Pe0kYtgJg mHat7FIEsTj/Q9l3zcSpeAl17Ca864jzlFOT29bVpGTxZLgEU6pc/PMx6dZIeUN88z9iGAemGnI AYYwk4akZzmSgicpPUgtRI+CvHW8c1XJ7+//+PNv0jgvv5OK1Z2mUWL/sHT+bB5u1SWFf+jWLdf XLs+AyQjdSkNBMULaXsBMWG3ErwaHkiEXcZ+pu3RI9sDErE3zJgy9s2ISCOdNR7pukqSDm3qSzj FDpH7ODHd X-Received: by 2002:a05:6000:2890:b0:413:473f:5515 with SMTP id ffacd0b85a97d-4255781b8c5mr4654239f8f.48.1759393864275; Thu, 02 Oct 2025 01:31:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE4ucZ1fOA/YMiqmosZzRgjQwRAEjyV4n8kJLFGDWQ8ZgUtW3qOXBDy4pMckTJyp2VPL7ndHA== X-Received: by 2002:a05:6000:2890:b0:413:473f:5515 with SMTP id ffacd0b85a97d-4255781b8c5mr4654214f8f.48.1759393863857; Thu, 02 Oct 2025 01:31:03 -0700 (PDT) Received: from ?IPV6:2a01:e0a:280:24f0:576b:abc6:6396:ed4a? ([2a01:e0a:280:24f0:576b:abc6:6396:ed4a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8f45e9sm2646658f8f.51.2025.10.02.01.31.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Oct 2025 01:31:03 -0700 (PDT) Message-ID: <0b42d6a6-0b9d-478a-81d7-9e8203b02b8a@redhat.com> Date: Thu, 2 Oct 2025 10:31:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 04/18] hw/vfio/listener: Include missing 'exec/target_page.h' header To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: Peter Maydell , Jagannathan Raman , qemu-ppc@nongnu.org, Ilya Leoshkevich , Thomas Huth , Jason Herne , Peter Xu , kvm@vger.kernel.org, Christian Borntraeger , Halil Pasic , Matthew Rosato , Paolo Bonzini , "Michael S. Tsirkin" , Elena Ufimtseva , Richard Henderson , Harsh Prateek Bora , Fabiano Rosas , Eric Farman , qemu-arm@nongnu.org, qemu-s390x@nongnu.org, David Hildenbrand , Alex Williamson , Nicholas Piggin References: <20251001175448.18933-1-philmd@linaro.org> <20251001175448.18933-5-philmd@linaro.org> From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Content-Language: en-US, fr Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: <20251001175448.18933-5-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.518, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 10/1/25 19:54, Philippe Mathieu-Daudé wrote: > The "exec/target_page.h" header is indirectly pulled from > "system/ram_addr.h". Include it explicitly, in order to > avoid unrelated issues when refactoring "system/ram_addr.h": > > hw/vfio/listener.c: In function ‘vfio_ram_discard_register_listener’: > hw/vfio/listener.c:258:28: error: implicit declaration of function ‘qemu_target_page_size’; did you mean ‘qemu_ram_pagesize’? > 258 | int target_page_size = qemu_target_page_size(); > | ^~~~~~~~~~~~~~~~~~~~~ > | qemu_ram_pagesize > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Richard Henderson > --- > hw/vfio/listener.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/vfio/listener.c b/hw/vfio/listener.c > index a2c19a3cec1..b5cefc9395c 100644 > --- a/hw/vfio/listener.c > +++ b/hw/vfio/listener.c > @@ -25,6 +25,7 @@ > #endif > #include > > +#include "exec/target_page.h" > #include "hw/vfio/vfio-device.h" > #include "hw/vfio/pci.h" > #include "system/address-spaces.h" Reviewed-by: Cédric Le Goater Thanks, C.