From: schspa <schspa@gmail.com>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
Laszlo Ersek <lersek@redhat.com>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"Kevin Zhao" <kevin.zhao@linaro.org>,
"Alistair Francis" <alistair@alistair23.me>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-arm <qemu-arm@nongnu.org>,
"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [PATCH] arm: xlnx-versal: fix virtio-mmio base address assignment
Date: Mon, 08 Feb 2021 13:34:02 +0800 [thread overview]
Message-ID: <0b4b2fcdb148bf35cbffbd9cd40ce1b88f883f0c.camel@gmail.com> (raw)
In-Reply-To: <20210205140807.GH477672@toto>
On Fri, 2021-02-05 at 15:08 +0100, Edgar E. Iglesias wrote:
> Thanks, that matches how I thought things should work.
>
> I wonder if virtio_mmio_bus_get_dev_path() really should be peeking
> into
> Sysbus internals mmio[].addr?
>
I think mmio[].addr needs to be given a meaningful value even if we
don't use it.
> Sysbus mmio[].addr looks like a candidate for removal if we ever get
> rid
> of the default system_memory...
>
> I don't have any good suggestions how to fix this. I guess we could
> wrap
> memory_region_add_subregion() with a sysbus version of it that sets
> mmio[].addr but that seems like a step backwards to me.
> Perhaps there's a way fix this in virtio_mmio_bus_get_dev_path()?
I think we can change virtio_mmio_bus_get_dev_path() with the following
methods.
1. modify TYPE_VIRTIO_MMIO:
add a prop to specify a unique device_path for virtio_mmio TypeInfo.
2. modify TYPE_VIRTIO_MMIO_BUS
add a global static instance count to generate a unique device path.
--
schspa <schspa@gmail.com>
next prev parent reply other threads:[~2021-02-08 17:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 6:58 [PATCH] arm: xlnx-versal: fix virtio-mmio base address assignment schspa
2021-02-04 8:19 ` Philippe Mathieu-Daudé
2021-02-04 9:04 ` schspa
2021-02-05 7:53 ` Philippe Mathieu-Daudé
2021-02-05 10:03 ` Peter Maydell
2021-02-05 10:31 ` Philippe Mathieu-Daudé
2021-02-05 11:18 ` Peter Maydell
2021-02-05 14:08 ` Edgar E. Iglesias
2021-02-08 5:34 ` schspa [this message]
2021-02-08 11:57 ` Laszlo Ersek
2021-02-08 12:59 ` Peter Maydell
2021-02-25 5:36 ` [PATCH v4] virtio-mmio: improve virtio-mmio get_dev_path alog schspa
2021-03-05 11:57 ` Peter Maydell
2021-03-06 2:28 ` Shi Schspa
2021-02-25 6:35 ` [PATCH] arm: xlnx-versal: fix virtio-mmio base address assignment schspa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b4b2fcdb148bf35cbffbd9cd40ce1b88f883f0c.camel@gmail.com \
--to=schspa@gmail.com \
--cc=alistair@alistair23.me \
--cc=armbru@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=kevin.zhao@linaro.org \
--cc=lersek@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).