Re: [PATCH 1/3] target/arm: Set arm_v7m_tcg_ops cpu_exec_halt to arm_cpu_exec_halt()

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 3/6/24 18:09, Peter Maydell wrote:
> In commit a96edb687e76 we set the cpu_exec_halt field of the
> TCGCPUOps arm_tcg_ops to arm_cpu_exec_halt(), but we left the
> arm_v7m_tcg_ops struct unchanged.  That isn't wrong, because for
> M-profile FEAT_WFxT doesn't exist and the default handling for "no
> cpu_exec_halt method" is correct, but it's perhaps a little
> confusing.  We would also like to make setting the cpu_exec_halt
> method mandatory.
> 
> Initialize arm_v7m_tcg_ops cpu_exec_halt to the same function we use
> for A-profile.  (On M-profile we never set up the wfxt timer so there
> is no change in behaviour here.)
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   target/arm/internals.h   | 3 +++
>   target/arm/cpu.c         | 2 +-
>   target/arm/tcg/cpu-v7m.c | 1 +
>   3 files changed, 5 insertions(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>