From: Paul Durrant <xadimgnik@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>, qemu-devel@nongnu.org
Cc: "no Stabellini" <sstabellini@kernel.org>,
"Anthony Perard" <anthony.perard@citrix.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 4/5] hw/xen: Fix double-free in xen_console store_con_info()
Date: Mon, 17 Apr 2023 13:33:38 +0100 [thread overview]
Message-ID: <0b67440a-9c65-6606-5e24-6fb01e8543a3@xen.org> (raw)
In-Reply-To: <20230412185102.441523-5-dwmw2@infradead.org>
On 12/04/2023 19:51, David Woodhouse wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
>
> Coverity spotted a double-free (CID 1508254); we g_string_free(path) and
> then for some reason immediately call free(path) too.
>
> We should just use g_autoptr() for it anyway, which simplifies the code
> a bit.
>
> Fixes: 7a8a749da7d3 ("hw/xen: Move xenstore_store_pv_console_info to xen_console.c")
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
> ---
> hw/char/xen_console.c | 13 +++----------
> 1 file changed, 3 insertions(+), 10 deletions(-)
>
Reviewed-by: Paul Durrant <paul@xen.org>
next prev parent reply other threads:[~2023-04-17 12:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 18:50 [PATCH for-8.0 0/5] Xen emulation build/Coverity fixes David Woodhouse
2023-04-12 18:50 ` [PATCH 1/5] hw/xen: Simplify emulated Xen platform init David Woodhouse
2023-04-12 18:50 ` [PATCH 2/5] hw/xen: Fix memory leak in libxenstore_open() for Xen David Woodhouse
2023-04-17 12:28 ` Paul Durrant
2023-04-12 18:51 ` [PATCH 3/5] xen: Drop support for Xen versions below 4.7.1 David Woodhouse
2023-04-17 12:30 ` Paul Durrant
2023-04-12 18:51 ` [PATCH 4/5] hw/xen: Fix double-free in xen_console store_con_info() David Woodhouse
2023-04-12 18:59 ` Peter Maydell
2023-04-17 12:33 ` Paul Durrant [this message]
2023-04-12 18:51 ` [PATCH 5/5] hw/xen: Fix broken check for invalid state in xs_be_open() David Woodhouse
2023-04-12 18:57 ` Peter Maydell
2023-04-17 12:34 ` Paul Durrant
2023-04-12 18:55 ` [PATCH for-8.0 0/5] Xen emulation build/Coverity fixes Peter Maydell
2023-04-12 19:01 ` David Woodhouse
2023-04-12 19:08 ` David Woodhouse
2023-04-13 9:10 ` Peter Maydell
2023-04-12 20:09 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b67440a-9c65-6606-5e24-6fb01e8543a3@xen.org \
--to=xadimgnik@gmail.com \
--cc=anthony.perard@citrix.com \
--cc=berrange@redhat.com \
--cc=dwmw2@infradead.org \
--cc=eduardo@habkost.net \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sstabellini@kernel.org \
--cc=thuth@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).