Re: [PATCH v3 10/11] qdev: Make netdev properties work as list elements

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 9/11/23 18:42, Kevin Wolf wrote:
> The 'name' parameter of QOM setters is primarily used to specify the name
> of the currently parsed input element in the visitor interface. For
> top-level qdev properties, this is always set and matches 'prop->name'.
> 
> However, for list elements it is NULL, because each element of a list
> doesn't have a separate name. Passing a non-NULL value runs into
> assertion failures in the visitor code.
> 
> Therefore, using 'name' in error messages is not right for property
> types that are used in lists, because "(null)" (or even a segfault)
> isn't very helpful to identify what QEMU is complaining about.
> 
> Change netdev properties to use 'prop->name' instead, which will contain
> the name of the array property after switching array properties to lists
> in the external interface. (This is still not perfect, as it doesn't
> identify which element in the list caused the error, but strictly better
> than before.)
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>   hw/core/qdev-properties-system.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>