From: Thomas Huth <thuth@redhat.com>
To: Zhang Chen <chen.zhang@intel.com>,
Li Zhijian <lizhijian@cn.fujitsu.com>,
Zhang Chen <zhangckid@gmail.com>,
Jason Wang <jasowang@redhat.com>,
qemu-dev <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] net/colo-compare.c: Remove duplicated code
Date: Mon, 14 Jan 2019 15:30:30 +0100 [thread overview]
Message-ID: <0b78cb56-aab1-aa20-3e38-bf7db25151af@redhat.com> (raw)
In-Reply-To: <20190114140510.7161-1-chen.zhang@intel.com>
On 2019-01-14 15:05, Zhang Chen wrote:
> From: Zhang Chen <chen.zhang@intel.com>
>
> Fix duplicated code:
> https://bugs.launchpad.net/qemu/+bug/1811499
>
> Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> ---
> net/colo-compare.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/net/colo-compare.c b/net/colo-compare.c
> index 9156ab3349..fa3fd0632d 100644
> --- a/net/colo-compare.c
> +++ b/net/colo-compare.c
> @@ -285,14 +285,6 @@ static bool colo_mark_tcp_pkt(Packet *ppkt, Packet *spkt,
> {
> *mark = 0;
>
> - if (ppkt->tcp_seq == spkt->tcp_seq && ppkt->seq_end == spkt->seq_end) {
> - if (colo_compare_packet_payload(ppkt, spkt,
> - ppkt->header_size, spkt->header_size,
> - ppkt->payload_size)) {
> - *mark = COLO_COMPARE_FREE_SECONDARY | COLO_COMPARE_FREE_PRIMARY;
> - return true;
> - }
> - }
> if (ppkt->tcp_seq == spkt->tcp_seq && ppkt->seq_end == spkt->seq_end) {
> if (colo_compare_packet_payload(ppkt, spkt,
> ppkt->header_size, spkt->header_size,
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2019-01-14 14:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 14:05 [Qemu-devel] [PATCH] net/colo-compare.c: Remove duplicated code Zhang Chen
2019-01-14 14:30 ` Thomas Huth [this message]
2019-01-14 16:44 ` Philippe Mathieu-Daudé
2019-01-15 8:06 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b78cb56-aab1-aa20-3e38-bf7db25151af@redhat.com \
--to=thuth@redhat.com \
--cc=chen.zhang@intel.com \
--cc=jasowang@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).