From: Thomas Huth <thuth@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Kyle Evans" <kevans@freebsd.org>, "Warner Losh" <imp@bsdimp.com>
Subject: Re: [RFC PATCH 0/2] Make the core disassembler functions target-independent
Date: Mon, 8 May 2023 16:28:42 +0200 [thread overview]
Message-ID: <0b96a5c9-26ac-1878-9a4b-72a87e47ea17@redhat.com> (raw)
In-Reply-To: <5b21cdb6-fbc6-b9fd-edcc-6ca7e4c88885@linaro.org>
On 08/05/2023 16.04, Richard Henderson wrote:
> On 5/8/23 14:37, Thomas Huth wrote:
>> Move disas.c into the target-independent source set, so that we
>> only have to compile this code once instead multiple times (one
>> time for each target).
>>
>> Marked as RFC since we have to replace the target_ulongs here
>> with hwaddr, and the TARGET_FMT_lx with HWADDR_FMT_plx, which is
>> a little bit ugly ... what's your opinion?
>>
>> Thomas Huth (2):
>> disas: Move softmmu specific code to separate file
>> disas: Move disas.c into the target-independent source set
>
> Patches 79-83 from
>
> https://patchew.org/QEMU/20230503072331.1747057-1-richard.henderson@linaro.org/
>
> do the same thing, using uint64_t instead of hwaddr (it's not).
Ah, great, so I can scratch this from my list :-)
But FYI, you missed to update bsd-user/elfload.c in the patch that updates
linux-user/elfload.c.
Thomas
next prev parent reply other threads:[~2023-05-08 14:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 13:37 [RFC PATCH 0/2] Make the core disassembler functions target-independent Thomas Huth
2023-05-08 13:37 ` [RFC PATCH 1/2] disas: Move softmmu specific code to separate file Thomas Huth
2023-05-08 13:37 ` [RFC PATCH 2/2] disas: Move disas.c into the target-independent source set Thomas Huth
2023-05-08 14:04 ` [RFC PATCH 0/2] Make the core disassembler functions target-independent Richard Henderson
2023-05-08 14:28 ` Thomas Huth [this message]
2023-05-09 15:54 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b96a5c9-26ac-1878-9a4b-72a87e47ea17@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=laurent@vivier.eu \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).