qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>,
	QEMU Developers <qemu-devel@nongnu.org>,
	qemu-stable <qemu-stable@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Michael Roth <michael.roth@amd.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Peter Maydell <peter.maydell@linaro.org>
Subject: Re: stable-8.0.1 re-tagging?
Date: Tue, 30 May 2023 11:23:22 +0200	[thread overview]
Message-ID: <0ba18db1-9dc9-6eb2-a626-3c73fe33dfaa@redhat.com> (raw)
In-Reply-To: <4aa77e25-c224-c2aa-d17d-54d3d04f763e@tls.msk.ru>

On 30/05/2023 10.15, Michael Tokarev wrote:
> Hi!
> 
> Yesterday I pushed v8.0.1 tag for 8.0.1 stable qemu release, but in the
> process of publishing it, Michael Roth discovered a regression in iotest
> which we all overlooked when initial patch has been applied to master.
> 
> The commit in question is this one:
> 
> commit de79b52604e43fdeba6cee4f5af600b62169f2d2
> Author: Stefan Hajnoczi <stefanha@redhat.com>
> Date:   Tue May 2 17:11:19 2023 -0400
> 
>      block/export: call blk_set_dev_ops(blk, NULL, NULL)
> 
> It caused iotest 307 to fail, - qemu failed with Sig11. 
...
> And another lesson for me to learn, - actually 2 - first is to listen
> to myself, since my inner self did think about running more complete
> checks after a bunch of block-io changes which I picked up, but I didn't
> think about that with enough attention. And second is to verify whatever
> I "think" is true, instead of relying on own assumptions, - here, I was
> sure iotests are run within CI infrastructure, but nothing really indicates
> this is the case.

FYI, only a subset of the iotests are run during "make check" since some of 
them do not work reliable in all environments (e.g. non-Linux systems). To 
be more precise, only the ones marked with the "auto" group are run during 
"make check", and test 307 does not have the "auto" label, thus it is not 
run in the CI.

  HTH,
   Thomas



      parent reply	other threads:[~2023-05-30  9:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30  8:15 stable-8.0.1 re-tagging? Michael Tokarev
2023-05-30  8:28 ` Olaf Hering
2023-05-30  8:59   ` Michael Tokarev
2023-05-30  9:23 ` Thomas Huth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ba18db1-9dc9-6eb2-a626-3c73fe33dfaa@redhat.com \
    --to=thuth@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=mjt@tls.msk.ru \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).