From: Laurent Vivier <laurent@vivier.eu>
To: Mauro Matteo Cascella <mcascell@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] nubus-device: fix memory leak in nubus_device_realize
Date: Thu, 22 Dec 2022 18:32:48 +0100 [thread overview]
Message-ID: <0bb3a2a6-52b5-03cd-c036-f19d945a8cf2@vivier.eu> (raw)
In-Reply-To: <20221222172915.671597-1-mcascell@redhat.com>
Le 22/12/2022 à 18:29, Mauro Matteo Cascella a écrit :
> Local variable "name" is allocated through strdup_printf and should be
> freed with g_free() to avoid memory leak.
>
> Fixes: 3616f424 ("nubus-device: add romfile property for loading declaration ROMs")
> Signed-off-by: Mauro Matteo Cascella <mcascell@redhat.com>
> ---
> hw/nubus/nubus-device.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/nubus/nubus-device.c b/hw/nubus/nubus-device.c
> index 0f1852f671..49008e4938 100644
> --- a/hw/nubus/nubus-device.c
> +++ b/hw/nubus/nubus-device.c
> @@ -80,6 +80,7 @@ static void nubus_device_realize(DeviceState *dev, Error **errp)
> &error_abort);
> ret = load_image_mr(path, &nd->decl_rom);
> g_free(path);
> + g_free(name);
> if (ret < 0) {
> error_setg(errp, "could not load romfile \"%s\"", nd->romfile);
> return;
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
next prev parent reply other threads:[~2022-12-22 17:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 17:29 [PATCH] nubus-device: fix memory leak in nubus_device_realize Mauro Matteo Cascella
2022-12-22 17:32 ` Laurent Vivier [this message]
2022-12-23 10:53 ` Philippe Mathieu-Daudé
2023-01-24 20:58 ` Mauro Matteo Cascella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bb3a2a6-52b5-03cd-c036-f19d945a8cf2@vivier.eu \
--to=laurent@vivier.eu \
--cc=mcascell@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).