From: Eric Blake <eblake@redhat.com>
To: Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org
Cc: lvivier@redhat.com, dgilbert@redhat.com, peterx@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable
Date: Fri, 12 May 2017 14:52:14 -0500 [thread overview]
Message-ID: <0bbb5f93-83bb-47b9-e7dd-d0824f3d8b61@redhat.com> (raw)
In-Reply-To: <20170511163228.6666-2-quintela@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 796 bytes --]
On 05/11/2017 11:32 AM, Juan Quintela wrote:
> Those two capabilities were added through the command line. Notice that
> we just created them. This is just the boilerplate.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> --
>
> Make migrate_set_block_* take a boolean argument.
Question - do we support the orthogonal selection of all 4 combinations
under HMP 'migrate' (no argument, -b alone, -i alone, -b and -i
together), or are there only 3 actual states? If the latter, should we
represent this as a single enum-valued property, rather than as two
independent boolean properties?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-05-12 19:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 16:32 [Qemu-devel] [PATCH v2 0/3] Remove old MigrationParams Juan Quintela
2017-05-11 16:32 ` [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable Juan Quintela
2017-05-12 19:52 ` Eric Blake [this message]
2017-05-15 9:41 ` Juan Quintela
2017-05-15 9:46 ` Dr. David Alan Gilbert
2017-05-15 14:24 ` Eric Blake
2017-05-15 15:38 ` Markus Armbruster
2017-05-15 16:06 ` Juan Quintela
2017-05-16 6:49 ` Markus Armbruster
2017-05-15 15:56 ` Juan Quintela
2017-05-11 16:32 ` [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams Juan Quintela
2017-05-12 3:40 ` Peter Xu
2017-05-12 10:55 ` Juan Quintela
2017-05-12 19:59 ` Eric Blake
2017-05-15 9:48 ` Juan Quintela
2017-05-15 10:43 ` Dr. David Alan Gilbert
2017-05-15 14:28 ` Eric Blake
2017-05-15 15:59 ` Juan Quintela
2017-05-15 16:06 ` Markus Armbruster
2017-05-15 16:33 ` Juan Quintela
2017-05-15 16:38 ` Dr. David Alan Gilbert
2017-05-15 16:56 ` Juan Quintela
2017-05-15 17:27 ` Dr. David Alan Gilbert
2017-05-15 17:35 ` Juan Quintela
2017-05-15 17:38 ` Dr. David Alan Gilbert
2017-05-15 17:45 ` Juan Quintela
2017-05-15 18:32 ` Dr. David Alan Gilbert
2017-05-16 7:25 ` Markus Armbruster
2017-05-16 8:00 ` Juan Quintela
2017-05-15 10:05 ` Peter Xu
2017-05-11 16:32 ` [Qemu-devel] [PATCH 3/3] migration: Remove " Juan Quintela
2017-05-12 2:01 ` [Qemu-devel] [PATCH v2 0/3] " Hailiang Zhang
-- strict thread matches above, loose matches on Subject: below --
2017-04-25 10:30 [Qemu-devel] [PATCH " Juan Quintela
2017-04-25 10:30 ` [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bbb5f93-83bb-47b9-e7dd-d0824f3d8b61@redhat.com \
--to=eblake@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).