From: Johannes Thumshirn <jth@kernel.org>
To: Alistair Francis <alistair23@gmail.com>
Cc: qemu-devel@nongnu.org,
"Alistair Francis" <alistair@alistair23.me>,
"Javier Rodriguez" <josejavier.rodriguez@duagon.com>,
"Jorge Sanjuan García" <Jorge.SanjuanGarcia@duagon.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Dmitry Fomichev" <dmitry.fomichev@wdc.com>
Subject: Re: [PATCH v3 4/4] wdt_z069: Add support for MEN 16z069 Watchdog
Date: Mon, 17 Apr 2023 09:30:18 +0200 [thread overview]
Message-ID: <0bc87d37-49ef-c5e6-823b-c1d922fc4900@kernel.org> (raw)
In-Reply-To: <CAKmqyKOJoTsq04G-nJB81v9u_K4JmXAPa49O3GqWiFPTtaEfPg@mail.gmail.com>
On 17.04.23 07:04, Alistair Francis wrote:
>> +
>> +/* #define Z069_DEBUG 1 */
>> +
>> +#ifdef Z069_DEBUG
>> +#define z069_debug(fmt, ...) \
>> + fprintf(stderr, "wdt_z069: %s: "fmt, __func__, ##__VA_ARGS__)
>> +#else
>> +#define z069_debug(fmt, ...)
>> +#endif
> Same comment from the previous versions about using traces instead of
> macro prints
Of cause, you're right. I'm stupid, sorry.
Johannes
prev parent reply other threads:[~2023-04-17 7:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 17:49 [PATCH v3 0/4] Add emulation of MEN Chameleon Hardware Johannes Thumshirn
2023-04-10 17:49 ` [PATCH v3 1/4] Add MEN Chameleon Bus emulation Johannes Thumshirn
2023-04-10 17:49 ` [PATCH v3 2/4] Add MEN Chameleon Bus via PCI carrier Johannes Thumshirn
2023-04-17 3:14 ` Alistair Francis
2023-04-10 17:49 ` [PATCH v3 3/4] serial-mcb: Add serial via MEN chameleon bus Johannes Thumshirn
2023-04-10 17:49 ` [PATCH v3 4/4] wdt_z069: Add support for MEN 16z069 Watchdog Johannes Thumshirn
2023-04-17 5:04 ` Alistair Francis
2023-04-17 7:30 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bc87d37-49ef-c5e6-823b-c1d922fc4900@kernel.org \
--to=jth@kernel.org \
--cc=Jorge.SanjuanGarcia@duagon.com \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=dmitry.fomichev@wdc.com \
--cc=josejavier.rodriguez@duagon.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).