From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b56N2-0006Km-VN for qemu-devel@nongnu.org; Tue, 24 May 2016 03:03:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b56Mx-0001eL-W1 for qemu-devel@nongnu.org; Tue, 24 May 2016 03:03:16 -0400 Sender: Paolo Bonzini References: <1464008051-6429-1-git-send-email-pbonzini@redhat.com> <1464008051-6429-6-git-send-email-pbonzini@redhat.com> <20160524030422.GG14601@ad.usersys.redhat.com> From: Paolo Bonzini Message-ID: <0bd78472-aeed-3c3f-b9be-99f51a20e2ef@redhat.com> Date: Tue, 24 May 2016 09:02:54 +0200 MIME-Version: 1.0 In-Reply-To: <20160524030422.GG14601@ad.usersys.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/7] scsi-disk: add need_fua_emulation to SCSIDiskClass List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org On 24/05/2016 05:04, Fam Zheng wrote: > On Mon, 05/23 14:54, Paolo Bonzini wrote: > > scsi-block will be able to do FUA just by passing the request through > > to the LUN (which is also more efficient); there is no need to emulate > > it like we do for scsi-disk. > > Even for scsi-disk, shall we just use the block layer FUA fallback already by > passing BDRV_REQ_FUA in blk_aio_pwritev and simply the code in this series? That's a good idea but it should be done separately, I think. Thanks, Paolo