From: Laszlo Ersek <lersek@redhat.com>
To: "Cédric Le Goater" <clg@redhat.com>,
marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: kraxel@redhat.com
Subject: Re: [PATCH v4 0/3] WIP: ramfb: migration support
Date: Thu, 5 Oct 2023 16:16:01 +0200 [thread overview]
Message-ID: <0bdd14ac-2964-1da1-716f-7aa69e773129@redhat.com> (raw)
In-Reply-To: <2907c142-13c1-01ad-f603-e39983d65859@redhat.com>
On 10/5/23 14:01, Cédric Le Goater wrote:
> On 10/5/23 13:30, marcandre.lureau@redhat.com wrote:
>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>
>> Hi,
>>
>> Implement RAMFB migration, and add properties to enable it only on >= 8.2
>> machines, + a few related cleanups.
>>
>> Cedric, did you get the chance to test the VFIO display/ramfb code?
>
> Nope. I was busy with VFIO stuff. I haven't even read Laszlo's
> email yet. I will try this or next week.
>
> That said, could we avoid adding another migration property in
> VFIOPCIDevice and use the available "enable-migration" ?
I'm not entirely sure, but I suspect we can't / shouldn't do that.
"x-ramfb-migrate" is effectively a machine type compat prop, so if it
doesn't *precisely* line up with enable-migration (i.e., if they aren't
equivalent), then we shouldn't merge them. AFAICT, a 8.1 machine type
may have "enable-migration" set, but it should still have
"x-ramfb-migrate" clear.
Laszlo
next prev parent reply other threads:[~2023-10-05 14:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 11:30 [PATCH v4 0/3] WIP: ramfb: migration support marcandre.lureau
2023-10-05 11:30 ` [PATCH v4 1/3] ramfb: add " marcandre.lureau
2023-10-05 15:03 ` Laszlo Ersek
2023-10-05 11:30 ` [PATCH v4 2/3] ramfb-standalone: " marcandre.lureau
2023-10-05 15:03 ` Laszlo Ersek
2023-10-05 11:30 ` [PATCH v4 3/3] hw/vfio: add ramfb " marcandre.lureau
2023-10-05 15:10 ` Cédric Le Goater
2023-10-05 15:13 ` Laszlo Ersek
2023-10-05 16:34 ` Cédric Le Goater
2023-10-06 4:03 ` Laszlo Ersek
2023-10-05 12:01 ` [PATCH v4 0/3] WIP: ramfb: " Cédric Le Goater
2023-10-05 14:16 ` Laszlo Ersek [this message]
2023-10-05 14:16 ` Laszlo Ersek
2023-10-05 15:44 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bdd14ac-2964-1da1-716f-7aa69e773129@redhat.com \
--to=lersek@redhat.com \
--cc=clg@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).