From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35187) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fOKkv-00053u-C2 for qemu-devel@nongnu.org; Thu, 31 May 2018 06:24:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fOKks-0005MP-4z for qemu-devel@nongnu.org; Thu, 31 May 2018 06:24:29 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:53499) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fOKkr-0005Ky-U1 for qemu-devel@nongnu.org; Thu, 31 May 2018 06:24:26 -0400 Received: by mail-wm0-f66.google.com with SMTP id a67-v6so52845373wmf.3 for ; Thu, 31 May 2018 03:24:25 -0700 (PDT) References: <85e343de944def6154c599ecda53bc70688ab60a.1526913931.git.mkletzan@redhat.com> <20180530210829.GB18402@wheatley> <14132ba4-8fec-6082-f77a-7da69069f4a2@redhat.com> <20180531081952.GD24021@wheatley> From: Paolo Bonzini Message-ID: <0bdff338-e837-eee7-88d9-69304cb546e3@redhat.com> Date: Thu, 31 May 2018 12:24:20 +0200 MIME-Version: 1.0 In-Reply-To: <20180531081952.GD24021@wheatley> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [libvirt] [PATCH 2/5] qemu: Move checks for SMM from command-line creation into validation phase List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Martin Kletzander , Laszlo Ersek Cc: libvir-list@redhat.com, John Ferlan , qemu devel list , Gerd Hoffmann On 31/05/2018 10:19, Martin Kletzander wrote: >> > > Oh, it definitely helps. And I always enjoy when someone explains > low level details of something like you do, it makes me feel very > smart after I read it =) > > ...something about the shoulders of giants and stuff... > > I'll fix this up according to what you described, that is smm=on/off > will be possible to be specified whenever -machine supports smm=. That sounds like the right thing, thanks! Paolo