From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BB06C64EC7 for ; Sat, 25 Feb 2023 19:47:42 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pW0Vr-0005w8-Qi; Sat, 25 Feb 2023 14:47:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pW0Vq-0005vU-B4 for qemu-devel@nongnu.org; Sat, 25 Feb 2023 14:47:18 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pW0Vo-0002rX-MC for qemu-devel@nongnu.org; Sat, 25 Feb 2023 14:47:17 -0500 Received: by mail-wr1-x436.google.com with SMTP id q16so2449105wrw.2 for ; Sat, 25 Feb 2023 11:47:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=p6+n4uxbbZd3nhwEvXFG/eQ2+KKeBSbg2mq4ipy89RI=; b=KYd050Up1lNljMBMdEoJlwZHkQF45xDIT3Ol9BzOPuu+5pftSCwbJ10h3X9IPLY533 01cEZiI+84e9SZ0AeSxLxUdjEbaj63aLieMk6W/5+ohxHHTE5g6/2QkLxEprd5D0Inrj hfafKaxCe9pB4vTrksieZ/jskndr7km4yRdD3CRXVOeh6p9bPQ5BxeRTOh14zqkyud4S VWHkTDP7J7VuIqnMU8xWLgCL2QhkrI1AplGs3DVFvB/J1FfK0e21W3+/Vgoq6Lw1MP80 M2b5jTZAJ0OHeeyIZ6hpz2BGYFqEMPR0XRYWALJimSWrsRwufsV2R3joJQJEdVeNlBag zhaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=p6+n4uxbbZd3nhwEvXFG/eQ2+KKeBSbg2mq4ipy89RI=; b=Cj4ZZuxRZDXJ2wDOJUuZeF6/l+dXTVxSHJXVDTAd6p3LnGjte1DbqjvuEjTaoY2A/G Zonz3WPv0KXKM4zZatjWGIKo6xrfj5/hrAeZ6V6iHgNsrEuI2Mz3L8AX800o75/+Ui0k 8RedidIjbpWdwoU2fEpafgPZhm82SrWrhggaepQBjbpC96pMkihyuCwsNYkhI1Frk4Sf nGMcMfPqSa8sGyrRzGXVCuEPGZufs7EBEuqsNTk4jM6pyN+w5Zemj/YFnLj+8glE00gX L1MGBjk/2NU3etpWWym995mbmO9E7RrWAT2OPBh79xGEPnBOF9O/DAFrTsv+Z3zh6vKY GRNQ== X-Gm-Message-State: AO0yUKWnXFhzv3YsssdJ43fkZTO5XYEBX8urJgCphWiM/l8twNlbDgbi iFmbmN4EyjQiV2nINXFWmaWw2A== X-Google-Smtp-Source: AK7set/Gs/bozRhJqYnjNG8BYdP4z+zueU72bxKjpS9RTtloZLAF4tnU4IVkoBOctb4ElZo9ESBPpQ== X-Received: by 2002:a5d:4482:0:b0:2c7:1bee:6eca with SMTP id j2-20020a5d4482000000b002c71bee6ecamr5447041wrq.35.1677354435034; Sat, 25 Feb 2023 11:47:15 -0800 (PST) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id n3-20020a5d4203000000b002c57384dfe0sm2470734wrq.113.2023.02.25.11.47.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Feb 2023 11:47:14 -0800 (PST) Message-ID: <0bf1de13-5934-0f6a-79d0-a0a7862ed998@linaro.org> Date: Sat, 25 Feb 2023 20:47:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 45/76] target/mips: Fix trans_mult_acc return Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, jcmvbkbc@gmail.com, kbastian@mail.uni-paderborn.de, ysato@users.sourceforge.jp, gaosong@loongson.cn, jiaxun.yang@flygoat.com, tsimpson@quicinc.com, ale@rev.ng, mrolnik@gmail.com, edgar.iglesias@gmail.com References: <20230225091427.1817156-1-richard.henderson@linaro.org> <20230225091427.1817156-46-richard.henderson@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230225091427.1817156-46-richard.henderson@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.094, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 25/2/23 10:13, Richard Henderson wrote: > Success from trans_* subroutines should be true. > > Signed-off-by: Richard Henderson > --- > target/mips/tcg/vr54xx_translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/mips/tcg/vr54xx_translate.c b/target/mips/tcg/vr54xx_translate.c > index 3e2c98f2c6..a7d241e4e7 100644 > --- a/target/mips/tcg/vr54xx_translate.c > +++ b/target/mips/tcg/vr54xx_translate.c > @@ -53,7 +53,7 @@ static bool trans_mult_acc(DisasContext *ctx, arg_r *a, > tcg_temp_free(t0); > tcg_temp_free(t1); > > - return false; > + return true; Oops... Fixes: 5fa38eedbd ("target/mips: Convert Vr54xx MACC* opcodes to decodetree") Reviewed-by: Philippe Mathieu-Daudé Queued to mips-next, thanks!