qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
	mst@redhat.com, lulu@redhat.com, amorenoz@redhat.com,
	qemu-devel@nongnu.org
Subject: Re: [PATCH v3] docs: vhost-user: add Virtio status protocol feature
Date: Fri, 19 Jun 2020 17:21:34 +0800	[thread overview]
Message-ID: <0bfbabc8-37dc-e91a-3126-f87e853172ad@redhat.com> (raw)
In-Reply-To: <20200618134501.145747-1-maxime.coquelin@redhat.com>


On 2020/6/18 下午9:45, Maxime Coquelin wrote:
> This patch specifies the VHOST_USER_SET_STATUS and
> VHOST_USER_GET_STATUS requests, which are sent by
> the master to update and query the Virtio status
> in the backend.
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> Changes since v2:
> =================
> - Typo: fix missing # (Jason)
>
> Changes since v1:
> =================
> - Only keep the spec part in this patch, the implementation will
>    be part of Cindy's Vhost vDPA series it depends on. The goal is
>    to be able to implement it in next DPDK release even if Qemu part
>    is not merged.
> - Add GET_STATUS after discussions with Michael and Jason. It can
>    be used by the master to ensure FEATURES_OK bit set is
>    acknowledged by the backend.
>
>   docs/interop/vhost-user.rst | 24 ++++++++++++++++++++++++
>   1 file changed, 24 insertions(+)
>
> diff --git a/docs/interop/vhost-user.rst b/docs/interop/vhost-user.rst
> index 688b7c6900..10e3e3475e 100644
> --- a/docs/interop/vhost-user.rst
> +++ b/docs/interop/vhost-user.rst
> @@ -816,6 +816,7 @@ Protocol features
>     #define VHOST_USER_PROTOCOL_F_RESET_DEVICE         13
>     #define VHOST_USER_PROTOCOL_F_INBAND_NOTIFICATIONS 14
>     #define VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS  15
> +  #define VHOST_USER_PROTOCOL_F_STATUS               16
>   
>   Master message types
>   --------------------
> @@ -1307,6 +1308,29 @@ Master message types
>     ``VHOST_USER_ADD_MEM_REG`` message, this message is used to set and
>     update the memory tables of the slave device.
>   
> +``VHOST_USER_SET_STATUS``
> +  :id: 39
> +  :equivalent ioctl: VHOST_VDPA_SET_STATUS
> +  :slave payload: N/A
> +  :master payload: ``u64``
> +
> +  When the ``VHOST_USER_PROTOCOL_F_STATUS`` protocol feature has been
> +  successfully negotiated, this message is submitted by the master to
> +  notify the backend with updated device status as defined in the Virtio
> +  specification.
> +
> +``VHOST_USER_GET_STATUS``
> +  :id: 40
> +  :equivalent ioctl: VHOST_VDPA_GET_STATUS
> +  :slave payload: ``u64``
> +  :master payload: N/A
> +
> +  When the ``VHOST_USER_PROTOCOL_F_STATUS`` protocol feature has been
> +  successfully negotiated, this message is submitted by the master to
> +  query the backend for its device status as defined in the Virtio
> +  specification.
> +
> +
>   Slave message types
>   -------------------
>   


Acked-by: Jason Wang <jasowang@redhat.com>




  parent reply	other threads:[~2020-06-19  9:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18 13:45 [PATCH v3] docs: vhost-user: add Virtio status protocol feature Maxime Coquelin
2020-06-18 14:25 ` no-reply
2020-06-19  9:21 ` Jason Wang [this message]
2020-06-23 14:52 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0bfbabc8-37dc-e91a-3126-f87e853172ad@redhat.com \
    --to=jasowang@redhat.com \
    --cc=amorenoz@redhat.com \
    --cc=lulu@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).