* [PATCH] hw/xen_evtchn: Initialize flush_kvm_routes
@ 2024-03-29 11:39 Artem Chernyshev
2024-03-29 12:52 ` Philippe Mathieu-Daudé
2024-04-02 10:54 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Artem Chernyshev @ 2024-03-29 11:39 UTC (permalink / raw)
To: David Woodhouse
Cc: Artem Chernyshev, Paul Durrant, Michael S . Tsirkin,
Marcel Apfelbaum, qemu-devel, Oleg Sviridov
In xen_evtchn_soft_reset() variable flush_kvm_routes can
be used before being initialized.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Oleg Sviridov <oleg.sviridov@red-soft.ru>
Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>
---
hw/i386/kvm/xen_evtchn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/kvm/xen_evtchn.c b/hw/i386/kvm/xen_evtchn.c
index a5052c0ea3..07bd0c9ab8 100644
--- a/hw/i386/kvm/xen_evtchn.c
+++ b/hw/i386/kvm/xen_evtchn.c
@@ -1097,7 +1097,7 @@ static int close_port(XenEvtchnState *s, evtchn_port_t port,
int xen_evtchn_soft_reset(void)
{
XenEvtchnState *s = xen_evtchn_singleton;
- bool flush_kvm_routes;
+ bool flush_kvm_routes = false;
int i;
if (!s) {
--
2.37.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/xen_evtchn: Initialize flush_kvm_routes
2024-03-29 11:39 [PATCH] hw/xen_evtchn: Initialize flush_kvm_routes Artem Chernyshev
@ 2024-03-29 12:52 ` Philippe Mathieu-Daudé
2024-04-02 10:54 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-03-29 12:52 UTC (permalink / raw)
To: Artem Chernyshev, David Woodhouse
Cc: Paul Durrant, Michael S . Tsirkin, Marcel Apfelbaum, qemu-devel,
Oleg Sviridov
On 29/3/24 12:39, Artem Chernyshev wrote:
> In xen_evtchn_soft_reset() variable flush_kvm_routes can
> be used before being initialized.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Oleg Sviridov <oleg.sviridov@red-soft.ru>
> Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>
> ---
> hw/i386/kvm/xen_evtchn.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/xen_evtchn: Initialize flush_kvm_routes
2024-03-29 11:39 [PATCH] hw/xen_evtchn: Initialize flush_kvm_routes Artem Chernyshev
2024-03-29 12:52 ` Philippe Mathieu-Daudé
@ 2024-04-02 10:54 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-04-02 10:54 UTC (permalink / raw)
To: Artem Chernyshev, David Woodhouse
Cc: Paul Durrant, Michael S . Tsirkin, Marcel Apfelbaum, qemu-devel,
Oleg Sviridov
On 29/3/24 12:39, Artem Chernyshev wrote:
> In xen_evtchn_soft_reset() variable flush_kvm_routes can
> be used before being initialized.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Oleg Sviridov <oleg.sviridov@red-soft.ru>
> Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>
> ---
> hw/i386/kvm/xen_evtchn.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch queued, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-02 10:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-29 11:39 [PATCH] hw/xen_evtchn: Initialize flush_kvm_routes Artem Chernyshev
2024-03-29 12:52 ` Philippe Mathieu-Daudé
2024-04-02 10:54 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).