From: Eric Blake <eblake@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
libvir-list@redhat.com, "Hervé Poussineau" <hpoussin@reactos.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-ppc@nongnu.org, "Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH v4 20/20] audio: set default value for pcspk.iobase property
Date: Wed, 24 Jun 2020 07:26:53 -0500 [thread overview]
Message-ID: <0c0f22d4-2c74-7d7f-d577-73b85c2452d7@redhat.com> (raw)
In-Reply-To: <20200624113026.13343-21-kraxel@redhat.com>
On 6/24/20 6:30 AM, Gerd Hoffmann wrote:
> Allows to drop the explicit qdev_prop_set_uint32 call in pcspk_init.
"allows to $verb" is not idiomatic, better is "allows ${verb}ing"
[Allows dropping] or "allows $subject to $verb" [Allows us to drop].
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> include/hw/audio/pcspk.h | 6 +-----
> hw/audio/pcspk.c | 2 +-
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2020-06-24 12:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 11:30 [PATCH v4 00/20] audio: deprecate -soundhw Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 01/20] stubs: add isa_create_simple Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 02/20] stubs: add pci_create_simple Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 03/20] audio: add deprecated_register_soundhw Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 04/20] audio: deprecate -soundhw ac97 Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 05/20] audio: deprecate -soundhw es1370 Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 06/20] audio: deprecate -soundhw adlib Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 07/20] audio: deprecate -soundhw cs4231a Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 08/20] audio: deprecate -soundhw gus Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 09/20] audio: deprecate -soundhw sb16 Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 10/20] audio: deprecate -soundhw hda Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 11/20] pc_basic_device_init: pass PCMachineState Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 12/20] pc_basic_device_init: drop has_pit arg Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 13/20] pc_basic_device_init: drop no_vmport arg Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 14/20] softmmu: initialize spice and audio earlier Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 15/20] audio: rework pcspk_init() Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 16/20] audio: create pcspk device early Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 17/20] audio: deprecate -soundhw pcspk Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 18/20] audio: add soundhw deprecation notice Gerd Hoffmann
2020-06-24 12:24 ` Eric Blake
2020-06-24 11:30 ` [PATCH v4 19/20] pcspk: update docs/system/target-i386-desc.rst.inc Gerd Hoffmann
2020-06-24 11:30 ` [PATCH v4 20/20] audio: set default value for pcspk.iobase property Gerd Hoffmann
2020-06-24 12:26 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c0f22d4-2c74-7d7f-d577-73b85c2452d7@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=hpoussin@reactos.org \
--cc=kraxel@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).