From: Thomas Huth <thuth@redhat.com>
To: luoyonggang@gmail.com, "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "QEMU Trivial" <qemu-trivial@nongnu.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-level <qemu-devel@nongnu.org>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v7 2/4] gitignore: ignore a bit more
Date: Tue, 13 Oct 2020 11:01:50 +0200 [thread overview]
Message-ID: <0c0ff749-9b79-e24f-6576-e0a396db37d7@redhat.com> (raw)
In-Reply-To: <CAE2XoE_gYX9G7LS6q5GAMsAZAxpGe-M1nO=bei9+D5HKwhBnUw@mail.gmail.com>
On 13/10/2020 10.53, 罗勇刚(Yonggang Luo) wrote:
>
>
> On Tue, Oct 13, 2020 at 4:38 PM Philippe Mathieu-Daudé <philmd@redhat.com
> <mailto:philmd@redhat.com>> wrote:
>>
>> On 10/13/20 1:37 AM, Yonggang Luo wrote:
>> > Enable the creating multiple build directory at the source root.
>> > Ignore /meson/ and /roms/ for better search experience.
>> >
>> > Signed-off-by: Yonggang Luo <luoyonggang@gmail.com
> <mailto:luoyonggang@gmail.com>>
>> > ---
>> > .gitignore | 4 +++-
>> > 1 file changed, 3 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/.gitignore b/.gitignore
>> > index b32bca1315..f78ee9f297 100644
>> > --- a/.gitignore
>> > +++ b/.gitignore
>> > @@ -1,5 +1,5 @@
>> > /GNUmakefile
>> > -/build/
>> > +/build*/
The naming of your private build directories is IMHO something that should
not be part of the public .gitignore file. I think you can use your
~/.gitignore file for that.
>> > *.pyc
>> > .sdk
>> > .stgit-*
>> > @@ -10,3 +10,5 @@ TAGS
>> > *~
>> > *.ast_raw
>> > *.depend_raw
>> > +/meson/
>> > +/roms/**/*
>>
>> Why?
> As I said, help for searching tool ignore it, meson and roms are thirdparty
> packages.
Hmm, but "git status" should still show whether there are modifications in
the subdirectories, so IMHO this should not be ignored?
Thomas
next prev parent reply other threads:[~2020-10-13 9:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 23:37 [PATCH v7 0/4] Improve cirrus msys2 Yonggang Luo
2020-10-12 23:37 ` [PATCH v7 1/4] scripts: Convert qemu-version.sh to qemu-version.py Yonggang Luo
2020-10-12 23:37 ` [PATCH v7 2/4] gitignore: ignore a bit more Yonggang Luo
2020-10-13 8:38 ` Philippe Mathieu-Daudé
2020-10-13 8:53 ` 罗勇刚(Yonggang Luo)
2020-10-13 9:01 ` Thomas Huth [this message]
2020-10-13 9:23 ` 罗勇刚(Yonggang Luo)
2020-10-12 23:37 ` [PATCH v7 3/4] docs: Fixes build docs on msys2/mingw Yonggang Luo
2020-10-12 23:37 ` [PATCH v7 4/4] cirrus: Enable doc build " Yonggang Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c0ff749-9b79-e24f-6576-e0a396db37d7@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=luoyonggang@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).