From: "Tomáš Golembiovský" <tgolembi@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Eric Blake" <eblake@redhat.com>,
"Sameeh Jubran" <sjubran@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Olga Krishtal" <okrishtal@virtuozzo.com>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
"Tomáš Golembiovský" <tgolembi@redhat.com>
Subject: [Qemu-devel] [PATCH v5 03/14] qga: linux: return disk device in guest-get-fsinfo
Date: Tue, 23 Oct 2018 13:23:12 +0200 [thread overview]
Message-ID: <0c23b5d49b0f355197b94eaf8685ccca2b46eb06.1540293795.git.tgolembi@redhat.com> (raw)
In-Reply-To: <cover.1540293795.git.tgolembi@redhat.com>
Report device node of the disk on Linux (e.g. "/dev/sda2").
Requirs libudev.
Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
---
qga/commands-posix.c | 7 ++++++-
qga/qapi-schema.json | 3 ++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index d08719ba68..0c04937a13 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -950,7 +950,12 @@ static void build_guest_fsinfo_for_real_device(char const *syspath,
if (udev == NULL || udevice == NULL) {
g_debug("failed to query udev");
} else {
- const char *serial;
+ const char *devnode, *serial;
+ devnode = udev_device_get_devnode(udevice);
+ if (devnode != NULL) {
+ disk->dev = g_strdup(devnode);
+ disk->has_dev = true;
+ }
serial = udev_device_get_property_value(udevice, "ID_SERIAL");
if (serial != NULL && *serial != 0) {
disk->serial = g_strdup(serial);
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index 3bcda6257e..c6725b3ec8 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -835,6 +835,7 @@
# @target: target id
# @unit: unit id
# @serial: serial number (since: 3.1)
+# @dev: device node (POSIX) or device UNC (Windows) (since: 3.1)
#
# Since: 2.2
##
@@ -842,7 +843,7 @@
'data': {'pci-controller': 'GuestPCIAddress',
'bus-type': 'GuestDiskBusType',
'bus': 'int', 'target': 'int', 'unit': 'int',
- '*serial': 'str'} }
+ '*serial': 'str', '*dev': 'str'} }
##
# @GuestFilesystemInfo:
--
2.19.0
next prev parent reply other threads:[~2018-10-23 11:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 11:23 [Qemu-devel] [PATCH v5 00/14] qga: report serial number and disk node Tomáš Golembiovský
2018-10-23 11:23 ` [Qemu-devel] [PATCH v5 01/14] configure: add test for libudev Tomáš Golembiovský
2018-10-23 11:23 ` [Qemu-devel] [PATCH v5 02/14] qga: linux: report disk serial number Tomáš Golembiovský
2018-10-23 11:23 ` Tomáš Golembiovský [this message]
2018-10-23 11:23 ` [Qemu-devel] [PATCH v5 04/14] qga-win: prevent crash when executing fsinfo command Tomáš Golembiovský
2018-10-23 11:23 ` [Qemu-devel] [PATCH v5 05/14] qga-win: fsinfo: pci-info: allow partial info Tomáš Golembiovský
2018-10-23 11:23 ` [Qemu-devel] [PATCH v5 06/14] *additonal fixup for NULL pci_controller field Tomáš Golembiovský
2018-10-23 11:23 ` [Qemu-devel] [PATCH v5 07/14] build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI Tomáš Golembiovský
2018-10-23 11:23 ` [Qemu-devel] [PATCH v5 08/14] qga-win: add debugging information Tomáš Golembiovský
2018-10-23 11:23 ` [Qemu-devel] [PATCH v5 09/14] qga-win: refactor disk properties (bus) Tomáš Golembiovský
2018-10-23 11:23 ` [Qemu-devel] [PATCH v5 10/14] qga-win: report disk serial number Tomáš Golembiovský
2018-10-23 11:23 ` [Qemu-devel] [PATCH v5 11/14] qga-win: refactor disk info Tomáš Golembiovský
2018-10-23 11:23 ` [Qemu-devel] [PATCH v5 12/14] qga-win: handle multi-disk volumes Tomáš Golembiovský
2018-10-23 11:23 ` [Qemu-devel] [PATCH v5 13/14] qga-win: return disk device in guest-get-fsinfo Tomáš Golembiovský
2018-10-23 11:23 ` [Qemu-devel] [PATCH v5 14/14] qga-win: demystify namespace stripping Tomáš Golembiovský
2018-10-30 3:27 ` [Qemu-devel] [PATCH v5 00/14] qga: report serial number and disk node Michael Roth
2018-10-30 10:00 ` Tomáš Golembiovský
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c23b5d49b0f355197b94eaf8685ccca2b46eb06.1540293795.git.tgolembi@redhat.com \
--to=tgolembi@redhat.com \
--cc=eblake@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=okrishtal@virtuozzo.com \
--cc=qemu-devel@nongnu.org \
--cc=sjubran@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).