Re: [Qemu-devel] [PATCH v2 04/17] target/sparc: convert to DisasContextBase

[Richard Henderson <richard.henderson@linaro.org>]

On 04/07/2018 04:19 AM, Emilio G. Cota wrote:
> Notes:
> 
> - pc and npc are left unmodified, since they can point to out-of-TB
>   jump targets.
> 
> - Got rid of last_pc in gen_intermediate_code(), using base.pc_next
>   instead. Only update pc_next (1) on a breakpoint (so that tb->size
>   includes the insn), and (2) after reading the current instruction
>   from memory. This allows us to use base.pc_next in the BP check,
>   which is what the translator loop does.
> 
> Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Cc: Artyom Tarasenko <atar4qemu@gmail.com>
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
>  target/sparc/translate.c | 92 +++++++++++++++++++++++-------------------------
>  1 file changed, 45 insertions(+), 47 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~