From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44082)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bHVPi-000711-0C
	for qemu-devel@nongnu.org; Mon, 27 Jun 2016 08:13:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bHVPh-0004Xh-4I
	for qemu-devel@nongnu.org; Mon, 27 Jun 2016 08:13:17 -0400
References: <1466892954-8684-1-git-send-email-eblake@redhat.com>
	<1466892954-8684-15-git-send-email-eblake@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <0c3def31-ff22-7d42-c0ff-37e74a7e39e0@redhat.com>
Date: Mon, 27 Jun 2016 14:13:05 +0200
MIME-Version: 1.0
In-Reply-To: <1466892954-8684-15-git-send-email-eblake@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 14/14] nbd: Implement
 NBD_CMD_WRITE_ZEROES on client
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>



On 26/06/2016 00:15, Eric Blake wrote:
> diff --git a/block/nbd.c b/block/nbd.c
> index 8d57220..049d1bd 100644
> --- a/block/nbd.c
> +++ b/block/nbd.c
> @@ -357,6 +357,7 @@ static int nbd_co_flush(BlockDriverState *bs)
>  static void nbd_refresh_limits(BlockDriverState *bs, Error **errp)
>  {
>      bs->bl.max_pdiscard = NBD_MAX_BUFFER_SIZE;
> +    bs->bl.max_pwrite_zeroes = NBD_MAX_BUFFER_SIZE;

I have probably asked before---is there any reason for these to be
limited, since the commands have no payload?

Thanks,

Paolo

>      bs->bl.max_transfer = NBD_MAX_BUFFER_SIZE;
>  }