From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: Re: [PATCH 05/11] softfloat: Pad array size in pick_nan_muladd
Date: Wed, 4 Dec 2024 07:19:41 +0100 [thread overview]
Message-ID: <0c448906-1f65-4433-aaf6-ec10943269a3@linaro.org> (raw)
In-Reply-To: <20241203203949.483774-6-richard.henderson@linaro.org>
On 3/12/24 21:39, Richard Henderson wrote:
> While all indices into val[] should be in [0-2], the mask
> applied is two bits. To help static analysis see there is
> no possibility of read beyond the end of the array, pad the
> array to 4 entries, with the final being (implicitly) NULL.
Squash in previous keeping the explanation? Regardless,
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> fpu/softfloat-parts.c.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
next prev parent reply other threads:[~2024-12-04 6:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 20:39 [PATCH for-10.0 00/11] fpu: pickNaN follow ups Richard Henderson
2024-12-03 20:39 ` [PATCH 01/11] target/arm: Copy entire float_status in is_ebf Richard Henderson
2024-12-04 6:14 ` Philippe Mathieu-Daudé
2024-12-05 13:28 ` Peter Maydell
2024-12-03 20:39 ` [PATCH 02/11] softfloat: Inline pickNaNMulAdd Richard Henderson
2024-12-04 6:05 ` Philippe Mathieu-Daudé
2024-12-05 13:30 ` Peter Maydell
2024-12-03 20:39 ` [PATCH 03/11] softfloat: Use goto for default nan case in pick_nan_muladd Richard Henderson
2024-12-04 6:15 ` Philippe Mathieu-Daudé
2024-12-03 20:39 ` [PATCH 04/11] softfloat: Remove which from parts_pick_nan_muladd Richard Henderson
2024-12-04 6:18 ` Philippe Mathieu-Daudé
2024-12-03 20:39 ` [PATCH 05/11] softfloat: Pad array size in pick_nan_muladd Richard Henderson
2024-12-04 6:19 ` Philippe Mathieu-Daudé [this message]
2024-12-03 20:39 ` [PATCH 06/11] softfloat: Move propagateFloatx80NaN to softfloat.c Richard Henderson
2024-12-05 13:33 ` Peter Maydell
2024-12-03 20:39 ` [PATCH 07/11] softfloat: Use parts_pick_nan in propagateFloatx80NaN Richard Henderson
2024-12-10 17:10 ` Peter Maydell
2024-12-03 20:39 ` [PATCH 08/11] softfloat: Inline pickNaN Richard Henderson
2024-12-04 6:10 ` Philippe Mathieu-Daudé
2024-12-03 20:39 ` [PATCH 09/11] softfloat: Share code between parts_pick_nan cases Richard Henderson
2024-12-05 13:37 ` Peter Maydell
2024-12-03 20:39 ` [PATCH 10/11] softfloat: Sink frac_cmp in parts_pick_nan until needed Richard Henderson
2024-12-05 13:48 ` Peter Maydell
2024-12-05 17:51 ` Richard Henderson
2024-12-05 17:52 ` Richard Henderson
2024-12-03 20:39 ` [PATCH 11/11] softfloat: Replace WHICH with RET in parts_pick_nan Richard Henderson
2024-12-04 6:12 ` Philippe Mathieu-Daudé
2024-12-10 17:23 ` [PATCH for-10.0 00/11] fpu: pickNaN follow ups Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c448906-1f65-4433-aaf6-ec10943269a3@linaro.org \
--to=philmd@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).