From: Richard Henderson <richard.henderson@linaro.org>
To: "Matheus K. Ferst" <matheus.ferst@eldorado.org.br>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: laurent@vivier.eu, groug@kaod.org, david@gibson.dropbear.id.au
Subject: Re: [PATCH 1/4] linux-user/ppc: Fix XER access in save/restore_user_regs
Date: Fri, 15 Oct 2021 11:24:20 -0700 [thread overview]
Message-ID: <0c4c402c-e9e3-f1da-2550-b28c8200a7aa@linaro.org> (raw)
In-Reply-To: <7925af5a-e8c4-0574-c131-4e86e8a0252c@eldorado.org.br>
On 10/15/21 7:54 AM, Matheus K. Ferst wrote:
>> While Appendix B does guarantee that "0" is and always will be an invalid instruction, I
>> wonder if the test itself would be clearer (i.e. self-documenting the intent) using
>> SIGTRAP and "trap".
>>
>>
>> r~
>
> It would be better, but cpu_loop is currently calling cpu_abort for POWERPC_EXCP_TRAP, so
> the test would fail. I'll see if I can fix that in another patch, and then we can change
> the test to use trap.
Fair enough.
r~
next prev parent reply other threads:[~2021-10-15 18:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 22:32 [PATCH 0/4] Fix incorrect accesses to XER matheus.ferst
2021-10-14 22:32 ` [PATCH 1/4] linux-user/ppc: Fix XER access in save/restore_user_regs matheus.ferst
2021-10-14 23:43 ` Richard Henderson
2021-10-15 14:54 ` Matheus K. Ferst
2021-10-15 18:24 ` Richard Henderson [this message]
2021-10-15 0:30 ` David Gibson
2021-10-14 22:32 ` [PATCH 2/4] target/ppc: Fix XER access in gdbstub matheus.ferst
2021-10-14 23:43 ` Richard Henderson
2021-10-15 0:31 ` David Gibson
2021-10-14 22:32 ` [PATCH 3/4] linux-user: Fix XER access in ppc version of elf_core_copy_regs matheus.ferst
2021-10-14 23:44 ` Richard Henderson
2021-10-14 22:32 ` [PATCH 4/4] target/ppc: Fix XER access in monitor matheus.ferst
2021-10-14 23:45 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c4c402c-e9e3-f1da-2550-b28c8200a7aa@linaro.org \
--to=richard.henderson@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=laurent@vivier.eu \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).