From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45117) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhGDo-0001Tb-5U for qemu-devel@nongnu.org; Mon, 14 Aug 2017 10:20:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhGDk-0006rq-1Z for qemu-devel@nongnu.org; Mon, 14 Aug 2017 10:20:00 -0400 References: <0d150f9d-bca2-7bbd-aecf-584d65646c23@redhat.com> From: Paolo Bonzini Message-ID: <0c6afe3c-5b8f-a7f2-41e4-8d780fa32cd6@redhat.com> Date: Mon, 14 Aug 2017 16:19:51 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 05/12] ppc4xx: Split off 4xx I2C emulation from ppc405_uc to its own file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: BALATON Zoltan Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Francois Revol , Alexander Graf , David Gibson On 14/08/2017 13:18, BALATON Zoltan wrote: > On Mon, 14 Aug 2017, Paolo Bonzini wrote: >> On 13/08/2017 19:04, BALATON Zoltan wrote: >>> Signed-off-by: BALATON Zoltan >>> --- >>> hw/ppc/Makefile.objs | 2 +- >>> hw/ppc/ppc405.h | 2 + >>> hw/ppc/ppc405_uc.c | 241 >>> --------------------------------------------- >>> hw/ppc/ppc4xx_i2c.c | 272 >>> +++++++++++++++++++++++++++++++++++++++++++++++++++ >>> 4 files changed, 275 insertions(+), 242 deletions(-) >>> create mode 100644 hw/ppc/ppc4xx_i2c.c >> >> Can you move it to hw/i2c while you're at it? > > I could if that's the preferred way but I've left it in hw/ppc because > this is not a generic device but specific to PPC SoCs and it was easier > to work with files in one dir than scattered through the tree. Should I > still move it to hw/i2c? Please do, having devices in hw/* helps when you do all-tree cleanups. Paolo