From: Thomas Huth <thuth@redhat.com>
To: Pierrick Bouvier <pierrick.bouvier@linaro.org>, qemu-devel@nongnu.org
Cc: "Daniel P . Berrangé" <berrange@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH] dockerfiles: fix default targets for debian-loongarch-cross
Date: Mon, 21 Oct 2024 07:33:54 +0200 [thread overview]
Message-ID: <0c6e46e6-a78f-4143-ae3e-2cc1c952233b@redhat.com> (raw)
In-Reply-To: <20241020213759.2168248-1-pierrick.bouvier@linaro.org>
On 20/10/2024 23.37, Pierrick Bouvier wrote:
> fix system target name, and remove --disable-system (which deactivates
> system target).
>
> Found using: make docker-test-build@debian-loongarch-cross V=1
>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
> tests/docker/dockerfiles/debian-loongarch-cross.docker | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/docker/dockerfiles/debian-loongarch-cross.docker b/tests/docker/dockerfiles/debian-loongarch-cross.docker
> index 79eab5621ef..538ab534902 100644
> --- a/tests/docker/dockerfiles/debian-loongarch-cross.docker
> +++ b/tests/docker/dockerfiles/debian-loongarch-cross.docker
> @@ -43,8 +43,8 @@ RUN curl -#SL https://github.com/loongson/build-tools/releases/download/2023.08.
> ENV PATH $PATH:/opt/cross-tools/bin
> ENV LD_LIBRARY_PATH /opt/cross-tools/lib:/opt/cross-tools/loongarch64-unknown-linux-gnu/lib:$LD_LIBRARY_PATH
>
> -ENV QEMU_CONFIGURE_OPTS --disable-system --disable-docs --disable-tools
> -ENV DEF_TARGET_LIST loongarch64-linux-user,loongarch-softmmu
> +ENV QEMU_CONFIGURE_OPTS --disable-docs --disable-tools
> +ENV DEF_TARGET_LIST loongarch64-linux-user,loongarch64-softmmu
> ENV MAKE /usr/bin/make
>
> # As a final step configure the user (if env is defined)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2024-10-21 5:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-20 21:37 [PATCH] dockerfiles: fix default targets for debian-loongarch-cross Pierrick Bouvier
2024-10-21 5:33 ` Thomas Huth [this message]
2024-10-21 5:39 ` Philippe Mathieu-Daudé
2024-10-21 8:25 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c6e46e6-a78f-4143-ae3e-2cc1c952233b@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).