* [PATCH] dockerfiles: fix default targets for debian-loongarch-cross
@ 2024-10-20 21:37 Pierrick Bouvier
2024-10-21 5:33 ` Thomas Huth
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Pierrick Bouvier @ 2024-10-20 21:37 UTC (permalink / raw)
To: qemu-devel
Cc: Daniel P . Berrangé, Alex Bennée,
Wainer dos Santos Moschetta, Philippe Mathieu-Daudé,
Thomas Huth, Pierrick Bouvier
fix system target name, and remove --disable-system (which deactivates
system target).
Found using: make docker-test-build@debian-loongarch-cross V=1
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
tests/docker/dockerfiles/debian-loongarch-cross.docker | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/docker/dockerfiles/debian-loongarch-cross.docker b/tests/docker/dockerfiles/debian-loongarch-cross.docker
index 79eab5621ef..538ab534902 100644
--- a/tests/docker/dockerfiles/debian-loongarch-cross.docker
+++ b/tests/docker/dockerfiles/debian-loongarch-cross.docker
@@ -43,8 +43,8 @@ RUN curl -#SL https://github.com/loongson/build-tools/releases/download/2023.08.
ENV PATH $PATH:/opt/cross-tools/bin
ENV LD_LIBRARY_PATH /opt/cross-tools/lib:/opt/cross-tools/loongarch64-unknown-linux-gnu/lib:$LD_LIBRARY_PATH
-ENV QEMU_CONFIGURE_OPTS --disable-system --disable-docs --disable-tools
-ENV DEF_TARGET_LIST loongarch64-linux-user,loongarch-softmmu
+ENV QEMU_CONFIGURE_OPTS --disable-docs --disable-tools
+ENV DEF_TARGET_LIST loongarch64-linux-user,loongarch64-softmmu
ENV MAKE /usr/bin/make
# As a final step configure the user (if env is defined)
--
2.39.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dockerfiles: fix default targets for debian-loongarch-cross
2024-10-20 21:37 [PATCH] dockerfiles: fix default targets for debian-loongarch-cross Pierrick Bouvier
@ 2024-10-21 5:33 ` Thomas Huth
2024-10-21 5:39 ` Philippe Mathieu-Daudé
2024-10-21 8:25 ` Alex Bennée
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2024-10-21 5:33 UTC (permalink / raw)
To: Pierrick Bouvier, qemu-devel
Cc: Daniel P . Berrangé, Alex Bennée,
Wainer dos Santos Moschetta, Philippe Mathieu-Daudé
On 20/10/2024 23.37, Pierrick Bouvier wrote:
> fix system target name, and remove --disable-system (which deactivates
> system target).
>
> Found using: make docker-test-build@debian-loongarch-cross V=1
>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
> tests/docker/dockerfiles/debian-loongarch-cross.docker | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/docker/dockerfiles/debian-loongarch-cross.docker b/tests/docker/dockerfiles/debian-loongarch-cross.docker
> index 79eab5621ef..538ab534902 100644
> --- a/tests/docker/dockerfiles/debian-loongarch-cross.docker
> +++ b/tests/docker/dockerfiles/debian-loongarch-cross.docker
> @@ -43,8 +43,8 @@ RUN curl -#SL https://github.com/loongson/build-tools/releases/download/2023.08.
> ENV PATH $PATH:/opt/cross-tools/bin
> ENV LD_LIBRARY_PATH /opt/cross-tools/lib:/opt/cross-tools/loongarch64-unknown-linux-gnu/lib:$LD_LIBRARY_PATH
>
> -ENV QEMU_CONFIGURE_OPTS --disable-system --disable-docs --disable-tools
> -ENV DEF_TARGET_LIST loongarch64-linux-user,loongarch-softmmu
> +ENV QEMU_CONFIGURE_OPTS --disable-docs --disable-tools
> +ENV DEF_TARGET_LIST loongarch64-linux-user,loongarch64-softmmu
> ENV MAKE /usr/bin/make
>
> # As a final step configure the user (if env is defined)
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dockerfiles: fix default targets for debian-loongarch-cross
2024-10-20 21:37 [PATCH] dockerfiles: fix default targets for debian-loongarch-cross Pierrick Bouvier
2024-10-21 5:33 ` Thomas Huth
@ 2024-10-21 5:39 ` Philippe Mathieu-Daudé
2024-10-21 8:25 ` Alex Bennée
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-10-21 5:39 UTC (permalink / raw)
To: Pierrick Bouvier, qemu-devel, Song Gao, WANG Xuerui
Cc: Daniel P . Berrangé, Alex Bennée,
Wainer dos Santos Moschetta, Thomas Huth
On 20/10/24 18:37, Pierrick Bouvier wrote:
> fix system target name, and remove --disable-system (which deactivates
> system target).
>
> Found using: make docker-test-build@debian-loongarch-cross V=1
>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
> tests/docker/dockerfiles/debian-loongarch-cross.docker | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/docker/dockerfiles/debian-loongarch-cross.docker b/tests/docker/dockerfiles/debian-loongarch-cross.docker
> index 79eab5621ef..538ab534902 100644
> --- a/tests/docker/dockerfiles/debian-loongarch-cross.docker
> +++ b/tests/docker/dockerfiles/debian-loongarch-cross.docker
> @@ -43,8 +43,8 @@ RUN curl -#SL https://github.com/loongson/build-tools/releases/download/2023.08.
> ENV PATH $PATH:/opt/cross-tools/bin
> ENV LD_LIBRARY_PATH /opt/cross-tools/lib:/opt/cross-tools/loongarch64-unknown-linux-gnu/lib:$LD_LIBRARY_PATH
>
> -ENV QEMU_CONFIGURE_OPTS --disable-system --disable-docs --disable-tools
> -ENV DEF_TARGET_LIST loongarch64-linux-user,loongarch-softmmu
> +ENV QEMU_CONFIGURE_OPTS --disable-docs --disable-tools
> +ENV DEF_TARGET_LIST loongarch64-linux-user,loongarch64-softmmu
> ENV MAKE /usr/bin/make
>
> # As a final step configure the user (if env is defined)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dockerfiles: fix default targets for debian-loongarch-cross
2024-10-20 21:37 [PATCH] dockerfiles: fix default targets for debian-loongarch-cross Pierrick Bouvier
2024-10-21 5:33 ` Thomas Huth
2024-10-21 5:39 ` Philippe Mathieu-Daudé
@ 2024-10-21 8:25 ` Alex Bennée
2 siblings, 0 replies; 4+ messages in thread
From: Alex Bennée @ 2024-10-21 8:25 UTC (permalink / raw)
To: Pierrick Bouvier
Cc: qemu-devel, Daniel P . Berrangé, Wainer dos Santos Moschetta,
Philippe Mathieu-Daudé, Thomas Huth
Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:
> fix system target name, and remove --disable-system (which deactivates
> system target).
>
> Found using: make docker-test-build@debian-loongarch-cross V=1
>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
> tests/docker/dockerfiles/debian-loongarch-cross.docker | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/docker/dockerfiles/debian-loongarch-cross.docker b/tests/docker/dockerfiles/debian-loongarch-cross.docker
> index 79eab5621ef..538ab534902 100644
> --- a/tests/docker/dockerfiles/debian-loongarch-cross.docker
> +++ b/tests/docker/dockerfiles/debian-loongarch-cross.docker
> @@ -43,8 +43,8 @@ RUN curl -#SL https://github.com/loongson/build-tools/releases/download/2023.08.
> ENV PATH $PATH:/opt/cross-tools/bin
> ENV LD_LIBRARY_PATH /opt/cross-tools/lib:/opt/cross-tools/loongarch64-unknown-linux-gnu/lib:$LD_LIBRARY_PATH
>
> -ENV QEMU_CONFIGURE_OPTS --disable-system --disable-docs --disable-tools
> -ENV DEF_TARGET_LIST loongarch64-linux-user,loongarch-softmmu
> +ENV QEMU_CONFIGURE_OPTS --disable-docs --disable-tools
> +ENV DEF_TARGET_LIST loongarch64-linux-user,loongarch64-softmmu
> ENV MAKE /usr/bin/make
>
> # As a final step configure the user (if env is defined)
Queued to testing/next, thanks.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-21 8:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-20 21:37 [PATCH] dockerfiles: fix default targets for debian-loongarch-cross Pierrick Bouvier
2024-10-21 5:33 ` Thomas Huth
2024-10-21 5:39 ` Philippe Mathieu-Daudé
2024-10-21 8:25 ` Alex Bennée
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).