From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE7B9C27C79 for ; Mon, 17 Jun 2024 10:20:35 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJ9T9-0008Uv-VQ; Mon, 17 Jun 2024 06:20:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJ9T8-0008UZ-GP; Mon, 17 Jun 2024 06:20:10 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJ9T6-00080m-Ve; Mon, 17 Jun 2024 06:20:10 -0400 Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45H9vr3R018689; Mon, 17 Jun 2024 10:20:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s=pp1; bh=a k597J1D1vKsqTD4P9F0FnCgl+4ZfyjOZqcoR0MRdPg=; b=WUPptUY6KjGRn0AvQ 0yJ2uMY5q0gdscQADwPJyXYQwduAI9Snj4dahrJAzRdYXRjZ34Ne2zhiyM8SFNKX wWbzjFituFvrEOCgTh+ZbR0V1Q2E4cg5tEL1Xf4ILleXt43syaepjFhzmOMOwb35 41LhTf/lu9DJHh6gPzvGslchwYUgACb8ag0hDVyJb3+DIbcOVnKPQvXfJHHz8TTc mPYIzr9C5wflj3bwj3fW6qDXT//CFEYFxBsTCaSItv6X92CgwpSKEwsQjWpUiJls bOziddAOTIe0ZwpZL4VjVl7xW8/5dCB4DENW9hjkwooMve/03DogPlUtnHblV15H JpXsw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ytjy90239-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Jun 2024 10:20:02 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 45HAK2pN023066; Mon, 17 Jun 2024 10:20:02 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ytjy90232-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Jun 2024 10:20:02 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 45H9oFmO023897; Mon, 17 Jun 2024 10:20:01 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3ysp9ps1u4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Jun 2024 10:20:01 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45HAJw5n19989206 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 17 Jun 2024 10:20:01 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D99EC5803F; Mon, 17 Jun 2024 10:19:58 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C7C2358070; Mon, 17 Jun 2024 10:19:55 +0000 (GMT) Received: from [9.124.223.158] (unknown [9.124.223.158]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 17 Jun 2024 10:19:55 +0000 (GMT) Message-ID: <0c72e586-9905-49e2-90ac-10426ea5691e@linux.ibm.com> Date: Mon, 17 Jun 2024 15:49:53 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/26] hw/ppc: Avoid using Monitor in xive_tctx_pic_print_info() To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Nicholas Piggin , =?UTF-8?B?RnLDqWTDqXJpYyBCYXJyYXQ=?= , David Gibson , =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Daniel Henrique Barboza , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= References: <20240610062105.49848-1-philmd@linaro.org> <20240610062105.49848-4-philmd@linaro.org> Content-Language: en-US From: Harsh Prateek Bora In-Reply-To: <20240610062105.49848-4-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: IZvEl1CBmQNtPcB4MMkF2bXIHv2XASRA X-Proofpoint-GUID: f5UtwpJLuM7YTx3X6S4BDVngcXQUYJbI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-17_08,2024-06-17_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 phishscore=0 malwarescore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 priorityscore=1501 mlxscore=0 mlxlogscore=784 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406170076 Received-SPF: pass client-ip=148.163.158.5; envelope-from=harshpb@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi Phillipe, On 6/10/24 11:50, Philippe Mathieu-Daudé wrote: > diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c > index fa23b27a2b..5854358f65 100644 > --- a/hw/ppc/pnv.c > +++ b/hw/ppc/pnv.c > @@ -1223,7 +1223,13 @@ static void pnv_chip_power9_intc_destroy(PnvChip *chip, PowerPCCPU *cpu) > static void pnv_chip_power9_intc_print_info(PnvChip *chip, PowerPCCPU *cpu, > Monitor *mon) > { > - xive_tctx_pic_print_info(XIVE_TCTX(pnv_cpu_state(cpu)->intc), mon); > + g_autoptr(GString) buf = g_string_new(""); > + g_autoptr(HumanReadableText) info = NULL; > + > + xive_tctx_pic_print_info(XIVE_TCTX(pnv_cpu_state(cpu)->intc), buf); > + > + info = human_readable_text_from_str(buf); > + monitor_puts(mon, info->human_readable_text); > } > > static void pnv_chip_power10_intc_create(PnvChip *chip, PowerPCCPU *cpu, > @@ -1267,7 +1273,13 @@ static void pnv_chip_power10_intc_destroy(PnvChip *chip, PowerPCCPU *cpu) > static void pnv_chip_power10_intc_print_info(PnvChip *chip, PowerPCCPU *cpu, > Monitor *mon) > { > - xive_tctx_pic_print_info(XIVE_TCTX(pnv_cpu_state(cpu)->intc), mon); > + g_autoptr(GString) buf = g_string_new(""); > + g_autoptr(HumanReadableText) info = NULL; > + > + xive_tctx_pic_print_info(XIVE_TCTX(pnv_cpu_state(cpu)->intc), buf); > + > + info = human_readable_text_from_str(buf); > + monitor_puts(mon, info->human_readable_text); > } > We have an existing code duplication in above two routines which is getting worse with these multi-lines getting duplicated. Could _power9_ be changed to inline and called from _power10_ as well? Thanks Harsh