From: Richard Henderson <richard.henderson@linaro.org>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH for-5.0? v2] target/xtensa: Statically allocate xtensa_insnbufs in DisasContext
Date: Tue, 7 Apr 2020 13:28:56 -0700 [thread overview]
Message-ID: <0c7467ea-3ef0-f827-df3b-73be8a5d92f1@linaro.org> (raw)
In-Reply-To: <CAMo8BfKzHNPNtRJEdkg4hDTVT5B+GhAQNn5PjOw5uShURqZxJw@mail.gmail.com>
On 4/7/20 12:17 PM, Max Filippov wrote:
> On Tue, Apr 7, 2020 at 12:07 PM Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> From: Max Filippov <jcmvbkbc@gmail.com>
>>
>> Rather than dynamically allocate, and risk failing to free
>> when we longjmp out of the translator, allocate the maximum
>> buffer size from any of the supported cpus.
>>
>> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
>> [rth: Merged the fixup in Max's reply to his original]
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>> target/xtensa/cpu.h | 3 +++
>> target/xtensa/helper.c | 1 +
>> target/xtensa/translate.c | 18 ++----------------
>> 3 files changed, 6 insertions(+), 16 deletions(-)
>
> I've re-posted it almost at the same time (:
> Should I take it, or do you have another plan for it?
I'm happy for you to take it.
r~
next prev parent reply other threads:[~2020-04-07 20:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 19:07 [PATCH for-5.0? v2] target/xtensa: Statically allocate xtensa_insnbufs in DisasContext Richard Henderson
2020-04-07 19:17 ` Max Filippov
2020-04-07 20:28 ` Richard Henderson [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-08 15:30 [PULL for-5.0 0/1] target/rx update for coverity warning Richard Henderson
2020-04-08 15:30 ` [PATCH for-5.0? v2] target/xtensa: Statically allocate xtensa_insnbufs in DisasContext Richard Henderson
2020-04-08 15:33 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c7467ea-3ef0-f827-df3b-73be8a5d92f1@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=jcmvbkbc@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).