From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF377C48BC3 for ; Mon, 19 Feb 2024 14:21:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rc4W5-00060p-JV; Mon, 19 Feb 2024 09:21:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rc4W2-0005zm-Um for qemu-devel@nongnu.org; Mon, 19 Feb 2024 09:21:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rc4Vy-0001MR-Mx for qemu-devel@nongnu.org; Mon, 19 Feb 2024 09:21:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708352461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=aUQ2JMLIVHpVte9U6jW+XZsF/MeL6vQZTZM7HcQExt0=; b=OL5qBdQFFZXKmjUiVvRDZdvZao/m9UxgmSRCEj0a09AUG63PjZqJgLGJfbSYh3kfMZ+uwX KcS+4/dp6HLoX2iyvy/J0KBcZLI/PPJ/Y+aBNXlZMrLUkneEtCzQqeWJlJRu7itqgiRkUd 42jgP/4BHWEjmz2mEOfD1IzSdWz6auc= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-f8Znvy9mPFiL6m_daqr3UA-1; Mon, 19 Feb 2024 09:21:00 -0500 X-MC-Unique: f8Znvy9mPFiL6m_daqr3UA-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-68f75239dcbso8101836d6.1 for ; Mon, 19 Feb 2024 06:21:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708352460; x=1708957260; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aUQ2JMLIVHpVte9U6jW+XZsF/MeL6vQZTZM7HcQExt0=; b=cjZaLj5h+5dEVv/AsXoTs2UJW+lqv2kdur9MSCjC1WYX8iG6fxZ/UoWRXJHskz/uee hmesedXDP6irL80i6LnJTEPmffSMiqYg1TwXxXWZAxMYCwgpt4Mh872vCdC6wKjH+LeX JGVtl3cwEFOOobpApfhhrO+A0fcuS4rBSn6bKNZ8HmaZ9RL/EwL9mES1boHIDik8jEcD G9G3LDI6e+5vPAtO7VIsWpGDhZU/YRNqoTa4Lke6sfo7HbhecIj5Gs/nrk7DXwEjBYRv PEnGH4L1bdvXNVnVYYyfgful4HtGbnO4+Kid/LxX3AbIzMXSsJCgTCYHEX9Z1m/POmPK edGA== X-Forwarded-Encrypted: i=1; AJvYcCV9yPrCoN73rHy5fOABpXCp2o5BysE9ZENllrG4q1ZeMUfvzaeun4kX/1uZ2CsAOS60nSk8qivbfIX/CEybRTPwmKAuxVA= X-Gm-Message-State: AOJu0YxZwE+ZnaRl9sdcthC+bD7a9xhKKvOhD9PikiKyhnPKr1YAD0SX VaYxKBs1A+ZUVSn4mKpueKZK++kcnaXqWW83qOWLT22Cx/whUsSc0LHmkkI/E5JYVxxgw/0/2Pk 6gbRecIPLVGgUKJp1IKZWAnKfOP7vjZ8ZvKlc61Gh9GxMJVPim+4/ X-Received: by 2002:a05:6214:21e8:b0:68f:60fd:d328 with SMTP id p8-20020a05621421e800b0068f60fdd328mr4885069qvj.43.1708352459926; Mon, 19 Feb 2024 06:20:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IE513EJeVddz8tLP8rs6YlfCwO5fulSKABnh+sTxo1Y6RAPQrFovow69WzsCp6RVSL1QMI9iQ== X-Received: by 2002:a05:6214:21e8:b0:68f:60fd:d328 with SMTP id p8-20020a05621421e800b0068f60fdd328mr4885048qvj.43.1708352459680; Mon, 19 Feb 2024 06:20:59 -0800 (PST) Received: from [192.168.0.9] (ip-109-43-177-48.web.vodafone.de. [109.43.177.48]) by smtp.gmail.com with ESMTPSA id mu19-20020a056214329300b0068f0a287159sm3279112qvb.87.2024.02.19.06.20.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Feb 2024 06:20:59 -0800 (PST) Message-ID: <0c7c448d-a651-4fa9-99d1-b08fcbaf5d5f@redhat.com> Date: Mon, 19 Feb 2024 15:20:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] tests/migration-test: Stick with gicv3 in aarch64 test Content-Language: en-US To: Peter Maydell Cc: peterx@redhat.com, qemu-devel@nongnu.org, =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Fabiano Rosas , Sebastian Ott , Eric Auger , qemu-arm References: <20240207005403.242235-1-peterx@redhat.com> <20240207005403.242235-2-peterx@redhat.com> <13862227-d782-46fe-b10f-94587c74745e@redhat.com> From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.072, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_SORBS_WEB=1.5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 19/02/2024 13.50, Peter Maydell wrote: > On Mon, 19 Feb 2024 at 11:54, Thomas Huth wrote: >> >> On 07/02/2024 01.54, peterx@redhat.com wrote: >>> From: Peter Xu >>> >>> Recently we introduced cross-binary migration test. It's always wanted >>> that migration-test uses stable guest ABI for both QEMU binaries in this >>> case, so that both QEMU binaries will be compatible on the migration >>> stream with the cmdline specified. >>> >>> Switch to a static gic version "3" rather than using version "max", so that >>> GIC should be stable now across any future QEMU binaries for migration-test. >>> >>> Here the version can actually be anything as long as the ABI is stable. We >>> choose "3" because it's the majority of what we already use in QEMU while >>> still new enough: "git grep gic-version=3" shows 6 hit, while version 4 has >>> no direct user yet besides "max". >>> >>> Note that even with this change, aarch64 won't be able to work yet with >>> migration cross binary test, but then the only missing piece will be the >>> stable CPU model. >>> >>> Reviewed-by: Daniel P. Berrangé >>> Signed-off-by: Peter Xu >>> --- >>> tests/qtest/migration-test.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c >>> index 7675519cfa..8a5bb1752e 100644 >>> --- a/tests/qtest/migration-test.c >>> +++ b/tests/qtest/migration-test.c >>> @@ -819,7 +819,7 @@ static int test_migrate_start(QTestState **from, QTestState **to, >>> } else if (strcmp(arch, "aarch64") == 0) { >>> memory_size = "150M"; >>> machine_alias = "virt"; >>> - machine_opts = "gic-version=max"; >>> + machine_opts = "gic-version=3"; >>> arch_opts = g_strdup_printf("-cpu max -kernel %s", bootpath); >>> start_address = ARM_TEST_MEM_START; >>> end_address = ARM_TEST_MEM_END; >> >> Looks like the migration test now fails on aarch64 when "configure" has been >> run with "--without-default-devices", since that disables the gicv3 in the >> binary ... is there a way to check whether the gicv3 is available, and use >> "=max" instead if it is not? > > A QEMU for AArch64 with no GICv3 is of very little practical use, > so I'm not sure it makes sense to allow users to build one like that. Ok, if it doesn't make too much sense to build without GICv3, maybe a patch like this could be the right solution: diff --git a/hw/intc/Kconfig b/hw/intc/Kconfig --- a/hw/intc/Kconfig +++ b/hw/intc/Kconfig @@ -12,10 +12,6 @@ config IOAPIC bool select I8259 -config ARM_GIC - bool - select MSI_NONBROKEN - config OPENPIC bool select MSI_NONBROKEN @@ -25,14 +21,18 @@ config APIC select MSI_NONBROKEN select I8259 +config ARM_GIC + bool + select ARM_GICV3_TCG if TCG + select ARM_GIC_KVM if KVM + select MSI_NONBROKEN + config ARM_GICV3_TCG bool - default y depends on ARM_GIC && TCG config ARM_GIC_KVM bool - default y depends on ARM_GIC && KVM config XICS ? At least this seems to fix the the migration-test when compiling with --without-default-devices. Thomas