From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 01/14] target/i386: Simplify get_memio_eip()
Date: Sun, 28 Apr 2024 11:11:18 -0700 [thread overview]
Message-ID: <0c7cd5ed-2256-4f6e-8d71-5a77c3c46252@linaro.org> (raw)
In-Reply-To: <20240427155714.53669-2-philmd@linaro.org>
On 4/27/24 08:57, Philippe Mathieu-Daudé wrote:
> The single call to get_memio_eip(), in cpu_report_tpr_access(),
> is protected by a check on tcg_enabled(). Since the call only
> exists when CONFIG_TCG is defined, we can slightly simplify.
Nack, that's not how things work.
By wrapping the whole function in an ifdef, the symbol isn't defined without CONFIG_TCG,
which means the if (0) { } block cannot compile.
r~
next prev parent reply other threads:[~2024-04-28 18:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-27 15:57 [PATCH 00/14] exec: Rework around CPUState user fields Philippe Mathieu-Daudé
2024-04-27 15:57 ` [PATCH 01/14] target/i386: Simplify get_memio_eip() Philippe Mathieu-Daudé
2024-04-28 18:11 ` Richard Henderson [this message]
2024-04-27 15:57 ` [PATCH 02/14] plugins: Update stale comment Philippe Mathieu-Daudé
2024-04-28 18:13 ` Richard Henderson
2024-04-27 15:57 ` [PATCH 03/14] plugins/api: Only include 'exec/ram_addr.h' with system emulation Philippe Mathieu-Daudé
2024-04-28 18:26 ` Richard Henderson
2024-04-27 15:57 ` [PATCH 04/14] exec: Include missing license in 'exec/cpu-common.h' Philippe Mathieu-Daudé
2024-04-28 18:26 ` Richard Henderson
2024-04-27 15:57 ` [PATCH 05/14] exec/cpu: Indent TARGET_PAGE_foo definitions Philippe Mathieu-Daudé
2024-04-28 18:27 ` Richard Henderson
2024-04-27 15:57 ` [PATCH 06/14] exec/cpu: Remove obsolete PAGE_RESERVED definition Philippe Mathieu-Daudé
2024-04-28 18:28 ` Richard Henderson
2024-04-27 15:57 ` [PATCH 07/14] exec/cpu: Remove duplicated PAGE_PASSTHROUGH definition Philippe Mathieu-Daudé
2024-04-28 18:28 ` Richard Henderson
2024-04-27 15:57 ` [PATCH 08/14] exec/cpu: Extract page-protection definitions to page-prot-common.h Philippe Mathieu-Daudé
2024-04-28 18:29 ` Richard Henderson
2024-04-27 15:57 ` [RFC PATCH 09/14] exec/cpu: Restrict user-specific page definitions Philippe Mathieu-Daudé
2024-04-28 18:31 ` Richard Henderson
2024-04-28 20:11 ` Philippe Mathieu-Daudé
2024-04-27 15:57 ` [PATCH 10/14] exec/user: Restrict 'syscall-trace.h' to user emulation Philippe Mathieu-Daudé
2024-04-28 18:32 ` Richard Henderson
2024-04-28 20:13 ` Philippe Mathieu-Daudé
2024-04-27 15:57 ` [PATCH 11/14] accel/tcg: Use cpu_loop_exit_requested() in cpu_loop_exec_tb() Philippe Mathieu-Daudé
2024-04-28 18:35 ` Richard Henderson
2024-04-27 15:57 ` [PATCH 12/14] accel/tcg: Remove pointless initialization of cflags_next_tb Philippe Mathieu-Daudé
2024-04-28 18:39 ` Richard Henderson
2024-04-27 15:57 ` [PATCH 13/14] accel/tcg: Reset TCG specific fields in tcg_cpu_reset_hold() Philippe Mathieu-Daudé
2024-04-28 18:46 ` Richard Henderson
2024-04-27 15:57 ` [PATCH 14/14] accel/tcg: Access tcg_cflags with getter / setter Philippe Mathieu-Daudé
2024-04-28 18:51 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c7cd5ed-2256-4f6e-8d71-5a77c3c46252@linaro.org \
--to=richard.henderson@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).