From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF260C433E0 for ; Fri, 5 Jun 2020 16:39:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4CFB206F0 for ; Fri, 5 Jun 2020 16:39:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4CFB206F0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhFNj-0003lm-2P for qemu-devel@archiver.kernel.org; Fri, 05 Jun 2020 12:39:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhFMl-0002S1-8F; Fri, 05 Jun 2020 12:38:48 -0400 Received: from lhrrgout.huawei.com ([185.176.76.210]:2109 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhFMj-0007ZT-SD; Fri, 05 Jun 2020 12:38:46 -0400 Received: from lhreml708-chm.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id E3EF75D0DFEEB45A0F3C; Fri, 5 Jun 2020 17:38:37 +0100 (IST) Received: from lhreml703-chm.china.huawei.com (10.201.108.52) by lhreml708-chm.china.huawei.com (10.201.108.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Fri, 5 Jun 2020 17:38:37 +0100 Received: from lhreml703-chm.china.huawei.com ([10.201.68.198]) by lhreml703-chm.china.huawei.com ([10.201.68.198]) with mapi id 15.01.1913.007; Fri, 5 Jun 2020 17:38:37 +0100 From: Salil Mehta To: Igor Mammedov , Andrew Jones Subject: RE: [Question] Regarding PMU initialization within the QEMU for ARM VCPUs Thread-Topic: [Question] Regarding PMU initialization within the QEMU for ARM VCPUs Thread-Index: AdY3+/mIYt1+TQdDQmymnxAa7PkUWwBhkdKAAHDt5AAABBY/YA== Date: Fri, 5 Jun 2020 16:38:37 +0000 Message-ID: <0c91f4bab5d24bb3a1e7ca36d1d57221@huawei.com> References: <20200603093745.dwfb55ny34az7rez@kamzik.brq.redhat.com> <20200605173116.55419a1e@redhat.com> In-Reply-To: <20200605173116.55419a1e@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.47.76.63] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Received-SPF: pass client-ip=185.176.76.210; envelope-from=salil.mehta@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/05 12:38:38 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "qemu-arm@nongnu.org" , "qemu-devel@nongnu.org" , "mst@redhat.com" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > From: Igor Mammedov [mailto:imammedo@redhat.com] > Sent: Friday, June 5, 2020 4:31 PM > To: Andrew Jones > Cc: Salil Mehta ; qemu-devel@nongnu.org; > qemu-arm@nongnu.org; Peter Maydell ; mst@redhat= .com > Subject: Re: [Question] Regarding PMU initialization within the QEMU for = ARM > VCPUs >=20 > On Wed, 3 Jun 2020 11:37:45 +0200 > Andrew Jones wrote: >=20 > > On Mon, Jun 01, 2020 at 03:04:33PM +0000, Salil Mehta wrote: > > > Hello, > > > I could see below within function fdt_add_pmu_nodes() part of > > > hw/arm/virt.c during virt machine initialization time: > ... > > > > > Q4. This function fdt_* looks to be wrongly named. The info > > > being initialized here shall be used even when ACPI is > > > being used. Initialization part and FDT info looked > > > mixed up here if I am right? > > > > Agreed. The function has the wrong name. mach-virt has many functions t= hat > > mix the initialization and fdt building together, but those functions a= re > > named something like create_foo(). Patches welcome. > that was where I gave up on cpu hotplug arm/virt the last time. Were you releasing the ARM objects as well? Or are you referring to some other problem? > Ideally we should split out from create_foo() all firmware generation cod= e > (fdt) and move it to virt_machine_done time + make sure that it could be > regenerated at reset time so guest would get updated FDT on reset. Agreed, just like ACPI part. That would be more cleaner.=20 Thanks Salil.