From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, wrampazz@redhat.com, ehabkost@redhat.com,
mtosatti@redhat.com, armbru@redhat.com, mreitz@redhat.com,
stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com,
alex.bennee@linaro.org, zhiwei_liu@c-sky.com, rth@twiddle.net
Subject: Re: [PATCH v5 02/15] replay: provide an accessor for rr filename
Date: Tue, 22 Sep 2020 14:58:47 +0200 [thread overview]
Message-ID: <0ca456d5-6b3e-2eed-46db-1b85fddb3928@redhat.com> (raw)
In-Reply-To: <160077694915.10249.14893037100345813692.stgit@pasha-ThinkPad-X280>
On 9/22/20 2:15 PM, Pavel Dovgalyuk wrote:
> From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
>
> This patch adds an accessor function for the name of the record/replay
> log file. Adding an accessor instead of making variable global,
> prevents accidental modification of this variable by other modules.
>
> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> include/sysemu/replay.h | 2 ++
> replay/replay.c | 5 +++++
> 2 files changed, 7 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-09-22 13:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 12:15 [PATCH v5 00/15] Reverse debugging Pavel Dovgalyuk
2020-09-22 12:15 ` [PATCH v5 01/15] replay: don't record interrupt poll Pavel Dovgalyuk
2020-09-22 12:57 ` Philippe Mathieu-Daudé
2020-09-22 12:15 ` [PATCH v5 02/15] replay: provide an accessor for rr filename Pavel Dovgalyuk
2020-09-22 12:58 ` Philippe Mathieu-Daudé [this message]
2020-09-22 12:15 ` [PATCH v5 03/15] qcow2: introduce icount field for snapshots Pavel Dovgalyuk
2020-09-22 12:16 ` [PATCH v5 04/15] migration: " Pavel Dovgalyuk
2020-09-22 12:16 ` [PATCH v5 05/15] qapi: introduce replay.json for record/replay-related stuff Pavel Dovgalyuk
2020-09-22 12:16 ` [PATCH v5 06/15] replay: introduce info hmp/qmp command Pavel Dovgalyuk
2020-09-22 12:16 ` [PATCH v5 07/15] replay: introduce breakpoint at the specified step Pavel Dovgalyuk
2020-09-22 12:16 ` [PATCH v5 08/15] replay: implement replay-seek command Pavel Dovgalyuk
2020-09-22 12:16 ` [PATCH v5 09/15] replay: flush rr queue before loading the vmstate Pavel Dovgalyuk
2020-09-22 12:16 ` [PATCH v5 10/15] gdbstub: add reverse step support in replay mode Pavel Dovgalyuk
2020-09-22 12:16 ` [PATCH v5 11/15] gdbstub: add reverse continue " Pavel Dovgalyuk
2020-09-22 12:16 ` [PATCH v5 12/15] replay: describe reverse debugging in docs/replay.txt Pavel Dovgalyuk
2020-09-22 12:16 ` [PATCH v5 13/15] docs: convert replay.txt to rst Pavel Dovgalyuk
2020-09-22 13:13 ` Paolo Bonzini
2020-09-23 6:22 ` Pavel Dovgalyuk
2020-09-22 12:16 ` [PATCH v5 14/15] replay: create temporary snapshot at debugger connection Pavel Dovgalyuk
2020-09-22 12:55 ` Philippe Mathieu-Daudé
2020-09-22 13:15 ` Philippe Mathieu-Daudé
2020-09-22 12:17 ` [PATCH v5 15/15] tests/acceptance: add reverse debugging test Pavel Dovgalyuk
2020-09-22 12:52 ` Philippe Mathieu-Daudé
2020-09-22 18:48 ` [PATCH v5 00/15] Reverse debugging no-reply
2020-09-22 18:53 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ca456d5-6b3e-2eed-46db-1b85fddb3928@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pavel.dovgalyuk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=wrampazz@redhat.com \
--cc=zhiwei_liu@c-sky.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).