From: Paolo Bonzini <pbonzini@redhat.com>
To: "misono.tomohiro@fujitsu.com" <misono.tomohiro@fujitsu.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"virtio-fs@redhat.com" <virtio-fs@redhat.com>
Subject: Re: [PATCH] configure: add option for virtiofsd
Date: Thu, 8 Oct 2020 12:43:54 +0200 [thread overview]
Message-ID: <0cab3544-b9c3-ae8f-3a9d-62d026d062e6@redhat.com> (raw)
In-Reply-To: <OSBPR01MB45820C38F613E3D38A565CCEE50B0@OSBPR01MB4582.jpnprd01.prod.outlook.com>
On 08/10/20 11:17, misono.tomohiro@fujitsu.com wrote:
> Hi Paolo
>
> Thanks a lot for the clear explanation. I will update the patch to follow the meson style.
> I realized virtiofsd actually needs tools (i.e. "--disable-tools --enable-virtiofsd"
> does not work with above meson.build) since virtiofsd requires libvhost_user which will
> be built ony when tools are built. So, I will keep the current dependency check (except 'have_system').
I'm thinking the behavior for --disable-tools --enable-virtiofsd would
be confusing. Therefore, another possibility is not introducing
--enable-virtiofsd. Instead, you can reuse --enable-vhost-user-fs:
- --enable-vhost-user-fs will fail if tools are enabled and cap-ng or
seccomp are unavailable
- --enable-vhost-user-fs --disable-tools will not look for cap-ng or
seccomp, because then the flag only controls inclusion of vhost-user-fs
in the emulators
- if "--enable-vhost-user-fs" is not specified and tools are enabled,
vhost-user-fs will only be included in the emulators if cap-ng and
seccomp are available
- if "--enable-vhost-user-fs" is not specified, tools are enabled and
cap-ng/seccomp are unavilable, vhost-user-fs will not be included in the
emulators either
- if "--enable-vhost-user-fs" is not specified but tools are not
enabled, configure will not check if cap-ng or seccomp.
In this case reusing most of your previous patch, and not moving
everything to meson, is totally okay. I don't want you to impose more
transition work.
Paolo
prev parent reply other threads:[~2020-10-08 10:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 9:29 [PATCH] configure: add option for virtiofsd Misono Tomohiro
2020-10-07 15:30 ` Paolo Bonzini
2020-10-08 9:17 ` misono.tomohiro
2020-10-08 9:55 ` [Virtio-fs] " Dr. David Alan Gilbert
2020-10-08 10:13 ` misono.tomohiro
2020-10-08 10:43 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cab3544-b9c3-ae8f-3a9d-62d026d062e6@redhat.com \
--to=pbonzini@redhat.com \
--cc=misono.tomohiro@fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).