From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH v2 07/21] include/exec/memattrs: Add two bits of space to MemTxAttrs
Date: Tue, 21 Feb 2023 12:38:44 +0100 [thread overview]
Message-ID: <0caee59e-2459-3cc8-1b31-39c54a2a59ed@linaro.org> (raw)
In-Reply-To: <14c3e3e0-1b1c-5b32-1bb9-8269e9facb7a@linaro.org>
On 21/2/23 11:50, Richard Henderson wrote:
> On 2/21/23 00:42, Philippe Mathieu-Daudé wrote:
>> On 21/2/23 11:01, Richard Henderson wrote:
>>> On 2/20/23 21:56, Philippe Mathieu-Daudé wrote:
>>>> 'secure' & 'user' seem mutually exclusive. If we get short in bits,
>>>> they could be shared.
>>>
>>> They are not. ARM has Secure EL0, or secure user mode.
>>
>> Oh, I misunderstood this field with user-emulation then (I tried
>> commenting it and my TCG/HVF build succeeded).
>>
>
> target/arm/ptw.c:2853: result->f.attrs.user = regime_is_user(env,
> mmu_idx);
>
> So... it shouldn't have built?
Eh correct... I guess I wasn't sitting in a directory with ARM target
selected when I tried that 🤦
../../hw/misc/armv7m_ras.c:19:15: error: no member named 'user' in
'struct MemTxAttrs'
if (attrs.user) {
~~~~~ ^
next prev parent reply other threads:[~2023-02-21 11:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 23:26 [PATCH v2 00/21] target/arm: Implement FEAT_RME Richard Henderson
2023-02-20 23:26 ` [PATCH v2 01/21] target/arm: Rewrite check_s2_mmu_setup Richard Henderson
2023-02-20 23:26 ` [PATCH v2 02/21] target/arm: Add isar_feature_aa64_rme Richard Henderson
2023-02-20 23:26 ` [PATCH v2 03/21] target/arm: Update SCR and HCR for RME Richard Henderson
2023-02-20 23:26 ` [PATCH v2 04/21] target/arm: SCR_EL3.NS may be RES1 Richard Henderson
2023-02-20 23:26 ` [PATCH v2 05/21] target/arm: Add RME cpregs Richard Henderson
2023-02-20 23:26 ` [PATCH v2 06/21] target/arm: Introduce ARMSecuritySpace Richard Henderson
2023-02-20 23:26 ` [PATCH v2 07/21] include/exec/memattrs: Add two bits of space to MemTxAttrs Richard Henderson
2023-02-21 7:56 ` Philippe Mathieu-Daudé
2023-02-21 10:01 ` Richard Henderson
2023-02-21 10:42 ` Philippe Mathieu-Daudé
2023-02-21 10:50 ` Richard Henderson
2023-02-21 11:38 ` Philippe Mathieu-Daudé [this message]
2023-02-20 23:26 ` [PATCH v2 08/21] target/arm: Adjust the order of Phys and Stage2 ARMMMUIdx Richard Henderson
2023-02-20 23:26 ` [PATCH v2 09/21] target/arm: Introduce ARMMMUIdx_Phys_{Realm,Root} Richard Henderson
2023-02-20 23:26 ` [PATCH v2 10/21] target/arm: Pipe ARMSecuritySpace through ptw.c Richard Henderson
2023-02-20 23:26 ` [PATCH v2 11/21] target/arm: NSTable is RES0 for the RME EL3 regime Richard Henderson
2023-02-20 23:26 ` [PATCH v2 12/21] target/arm: Handle Block and Page bits for security space Richard Henderson
2023-02-20 23:26 ` [PATCH v2 13/21] target/arm: Handle no-execute for Realm and Root regimes Richard Henderson
2023-02-20 23:26 ` [PATCH v2 14/21] target/arm: Use get_phys_addr_with_struct in S1_ptw_translate Richard Henderson
2023-02-20 23:26 ` [PATCH v2 15/21] target/arm: Move s1_is_el0 into S1Translate Richard Henderson
2023-02-20 23:26 ` [PATCH v2 16/21] target/arm: Use get_phys_addr_with_struct for stage2 Richard Henderson
2023-02-20 23:26 ` [PATCH v2 17/21] target/arm: Add GPC syndrome Richard Henderson
2023-02-20 23:26 ` [PATCH v2 18/21] target/arm: Implement GPC exceptions Richard Henderson
2023-02-20 23:26 ` [PATCH v2 19/21] target/arm: Implement the granule protection check Richard Henderson
2023-02-20 23:26 ` [NOTFORMERGE PATCH v2 20/21] target/arm: Enable RME for -cpu max Richard Henderson
2023-02-20 23:26 ` [NOTFORMERGE PATCH v2 21/21] hw/arm/virt: Add some memory for Realm Management Monitor Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0caee59e-2459-3cc8-1b31-39c54a2a59ed@linaro.org \
--to=philmd@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).