Re: [SPAM] [PATCH v3 02/30] hw/arm/aspeed: Make aspeed_machine_class_init_cpus_defaults() globally accessible

["Cédric Le Goater" <clg@kaod.org>]

On 11/3/25 10:27, Jamin Lin wrote:
> The function aspeed_machine_class_init_cpus_defaults() is now made
> globally visible so that it can be used by other Aspeed machine C files.
> 
> Previously, this function was declared as static, restricting its
> visibility to aspeed.c. Since future machine split files will also
> need to call this helper to initialize default CPU settings, its
> declaration has been moved to the common header aspeed.h and the
> static keyword has been removed.
> 
> No functional changes.
> 
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>

Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   include/hw/arm/aspeed.h | 10 ++++++++++
>   hw/arm/aspeed.c         |  2 +-
>   2 files changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/include/hw/arm/aspeed.h b/include/hw/arm/aspeed.h
> index 9d34be68b2..712014497e 100644
> --- a/include/hw/arm/aspeed.h
> +++ b/include/hw/arm/aspeed.h
> @@ -57,5 +57,15 @@ struct AspeedMachineClass {
>       bool vbootrom;
>   };
>   
> +/*
> + * aspeed_machine_class_init_cpus_defaults:
> + * @mc: the #MachineClass to be initialized.
> + *
> + * Initialize the default CPU configuration for an Aspeed machine class.
> + * This function sets the default, minimum, and maximum CPU counts
> + * to match the number of CPUs defined in the associated SoC class,
> + * and copies its list of valid CPU types.
> + */
> +void aspeed_machine_class_init_cpus_defaults(MachineClass *mc);
>   
>   #endif
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index 4c92f1e1d9..f23af5bf8c 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -1339,7 +1339,7 @@ static void aspeed_machine_class_props_init(ObjectClass *oc)
>                                             "Change the SPI Flash model");
>   }
>   
> -static void aspeed_machine_class_init_cpus_defaults(MachineClass *mc)
> +void aspeed_machine_class_init_cpus_defaults(MachineClass *mc)
>   {
>       AspeedMachineClass *amc = ASPEED_MACHINE_CLASS(mc);
>       AspeedSoCClass *sc = ASPEED_SOC_CLASS(object_class_by_name(amc->soc_name));