From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 502C0CCFA06 for ; Mon, 3 Nov 2025 10:00:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFrLl-0005fG-I3; Mon, 03 Nov 2025 04:59:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFrLh-0005eB-OW; Mon, 03 Nov 2025 04:59:41 -0500 Received: from smtpout1.mo529.mail-out.ovh.net ([178.32.125.2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFrLb-0007y5-5P; Mon, 03 Nov 2025 04:59:41 -0500 Received: from mxplan5.mail.ovh.net (unknown [10.109.231.115]) by mo529.mail-out.ovh.net (Postfix) with ESMTPS id 4d0RrP6Cm7z5w87; Mon, 3 Nov 2025 09:59:17 +0000 (UTC) Received: from kaod.org (37.59.142.114) by DAG8EX2.mxp5.local (172.16.2.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.61; Mon, 3 Nov 2025 10:59:16 +0100 Authentication-Results: garm.ovh; auth=pass (GARM-114S008ab4b56d1-1f1d-4d6b-ae0c-4afc0bf6b0cc, 25720A756895FCE40C516A1A344E2045610AA209) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: <0cb02e89-2f9b-4c12-aad7-024df507ee4f@kaod.org> Date: Mon, 3 Nov 2025 10:59:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [SPAM] [PATCH v3 02/30] hw/arm/aspeed: Make aspeed_machine_class_init_cpus_defaults() globally accessible To: Jamin Lin , Peter Maydell , Steven Lee , Troy Lee , Andrew Jeffery , Joel Stanley , "open list:All patches CC here" , "open list:ASPEED BMCs" CC: , References: <20251103092801.1282602-1-jamin_lin@aspeedtech.com> <20251103092801.1282602-3-jamin_lin@aspeedtech.com> From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Content-Language: en-US, fr Autocrypt: addr=clg@kaod.org; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSBDw6lkcmljIExl IEdvYXRlciA8Y2xnQGthb2Qub3JnPsLBeAQTAQIAIgUCW7yjdQIbAwYLCQgHAwIGFQgCCQoL BBYCAwECHgECF4AACgkQUaNDx8/77KGRSxAAuMJJMhJdj7acTcFtwof7CDSfoVX0owE2FJdd M43hNeTwPWlV5oLCj1BOQo0MVilIpSd9Qu5wqRD8KnN2Bv/rllKPqK2+i8CXymi9hsuzF56m 76wiPwbsX54jhv/VYY9Al7NBknh6iLYJiC/pgacRCHtSj/wofemSCM48s61s1OleSPSSvJE/ jYRa0jMXP98N5IEn8rEbkPua/yrm9ynHqi4dKEBCq/F7WDQ+FfUaFQb4ey47A/aSHstzpgsl TSDTJDD+Ms8y9x2X5EPKXnI3GRLaCKXVNNtrvbUd9LsKymK3WSbADaX7i0gvMFq7j51P/8yj neaUSKSkktHauJAtBNXHMghWm/xJXIVAW8xX5aEiSK7DNp5AM478rDXn9NZFUdLTAScVf7LZ VzMFKR0jAVG786b/O5vbxklsww+YXJGvCUvHuysEsz5EEzThTJ6AC5JM2iBn9/63PKiS3ptJ QAqzasT6KkZ9fKLdK3qtc6yPaSm22C5ROM3GS+yLy6iWBkJ/nEYh/L/du+TLw7YNbKejBr/J ml+V3qZLfuhDjW0GbeJVPzsENuxiNiBbyzlSnAvKlzda/sBDvxmvWhC+nMRQCf47mFr8Xx3w WtDSQavnz3zTa0XuEucpwfBuVdk4RlPzNPri6p2KTBhPEvRBdC9wNOdRBtsP9rAPjd52d73O wU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhWpOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNL SoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZKXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVU cP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwpbV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+ S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc 9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFUCSLB2AE4wXQkJbApye48qnZ09zc929df5gU6 hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iSYBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616d tb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6gLxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/ t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1c OY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0SdujWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475 KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/JxIqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8 o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoX ywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjKyKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0 IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9jhQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Ta d2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yops302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it +OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/pLHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1n HzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBUwYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVIS l73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lUXOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY 3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfAHQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4Pls ZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQizDiU6iOrUzBThaMhZO3i927SG2DwWDVzZlt KrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gDuVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: <20251103092801.1282602-3-jamin_lin@aspeedtech.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [37.59.142.114] X-ClientProxiedBy: DAG6EX1.mxp5.local (172.16.2.51) To DAG8EX2.mxp5.local (172.16.2.72) X-Ovh-Tracer-GUID: c7051019-839d-4663-8797-550045c66eb1 X-Ovh-Tracer-Id: 9004103033784404914 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTEDLsRmy/kriGTMH6u/lBQ9ULL8Eh/OVCz13Rq7snT58fT8xyyZ0dH75Q6pZPJtMn+sbLVtK83dFpEaVn2BMANRtNTjDlFIGEehUljEKBG8aB1/VlggRLZrB4j6WZ0vpDkWhqQwr51/R7FBCKHoHD1PT30oySGsBJJqGyxWsdUSiB14BlZ4+anmLoX4Vp43FJKznUpnr0P3uGxhxha6182pDemSUZpl4um/8gxc0KwkY4tAMXazpDvdpEr6v3aIRasDhcqCrBO4NX3y7kx9OWag5SMP+x0MAo3YOb3IqPATt1L5zzLJNoXfScUcxEl9BCtdDuI59+9f/cKUlT1CZqeGWoBlz4faXM3U0/wuO+7YMN4AX4cclpMvWlSap8KFIAgC/BsnH1gfJNB5BjtcNvOd8h2cEdeAWeLdENpZaeioHxf36mlpOOjyX7GfY/BwQ9lh8sDgxBBIxrHtt+6GkfuP+SaeGZyN/oPnU9s4hInAnHE0Zrsy4QB6qgVTxxs1B51wSytTeMq17FhKlrwZEonq/lGM2/ShKZRltNVLLmbshb5BruqqZlAjsnN9mLur9vvj1qRyZuoqZU0m1dh6gAhdv2n5/jtpITxzi5kGVfOo0fmpJRvWZWYaJKhV2ISzpqSsCnqECqYIC+7PzY8Z38frUrinAvN7CWCQ0Sv2RUy3Jg DKIM-Signature: a=rsa-sha256; bh=IzxzkEcixHXK/VySs0a3PICAlEYk5Usnn9e8Gpf+OzI=; c=relaxed/relaxed; d=kaod.org; h=From; s=ovhmo393970-selector1; t=1762163959; v=1; b=suMfje6ApWlGYBdGUkdwHBSBPM9C0TiF+3M/us9wN8gQa1lfihWYjaYju+LVqpkmVOxt1eiE UBTgztENv4hiabkdf2uYdBzUlv5+PxNRR06q6r7yKCDuJmKkknwsUkd6rEapXcsiTgpJVcbziTq EzdakgztxvVL8ct0jXlGxg3WCvByiKu7VMa1UUfHuFlPinTEPhIW2uhWcs8PtoohsKyzpAPRA0s h4MLPHOnMRcUW6qv4Wn3sakXFDy5W9QFV0uh5zFO6a1l45K8c8p7NxgpGmp+ta2UUeYl2lENaE+ AYSFQ+krAq3vdhrsCdxol6BYego20vThvBzy5UrC4mxxw== Received-SPF: pass client-ip=178.32.125.2; envelope-from=clg@kaod.org; helo=smtpout1.mo529.mail-out.ovh.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 11/3/25 10:27, Jamin Lin wrote: > The function aspeed_machine_class_init_cpus_defaults() is now made > globally visible so that it can be used by other Aspeed machine C files. > > Previously, this function was declared as static, restricting its > visibility to aspeed.c. Since future machine split files will also > need to call this helper to initialize default CPU settings, its > declaration has been moved to the common header aspeed.h and the > static keyword has been removed. > > No functional changes. > > Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Thanks, C. > --- > include/hw/arm/aspeed.h | 10 ++++++++++ > hw/arm/aspeed.c | 2 +- > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/include/hw/arm/aspeed.h b/include/hw/arm/aspeed.h > index 9d34be68b2..712014497e 100644 > --- a/include/hw/arm/aspeed.h > +++ b/include/hw/arm/aspeed.h > @@ -57,5 +57,15 @@ struct AspeedMachineClass { > bool vbootrom; > }; > > +/* > + * aspeed_machine_class_init_cpus_defaults: > + * @mc: the #MachineClass to be initialized. > + * > + * Initialize the default CPU configuration for an Aspeed machine class. > + * This function sets the default, minimum, and maximum CPU counts > + * to match the number of CPUs defined in the associated SoC class, > + * and copies its list of valid CPU types. > + */ > +void aspeed_machine_class_init_cpus_defaults(MachineClass *mc); > > #endif > diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c > index 4c92f1e1d9..f23af5bf8c 100644 > --- a/hw/arm/aspeed.c > +++ b/hw/arm/aspeed.c > @@ -1339,7 +1339,7 @@ static void aspeed_machine_class_props_init(ObjectClass *oc) > "Change the SPI Flash model"); > } > > -static void aspeed_machine_class_init_cpus_defaults(MachineClass *mc) > +void aspeed_machine_class_init_cpus_defaults(MachineClass *mc) > { > AspeedMachineClass *amc = ASPEED_MACHINE_CLASS(mc); > AspeedSoCClass *sc = ASPEED_SOC_CLASS(object_class_by_name(amc->soc_name));