From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C382C433E6 for ; Mon, 15 Feb 2021 13:34:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D92F660200 for ; Mon, 15 Feb 2021 13:34:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D92F660200 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58300 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBe1K-0004D1-Sy for qemu-devel@archiver.kernel.org; Mon, 15 Feb 2021 08:34:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBdxp-00016a-5O for qemu-devel@nongnu.org; Mon, 15 Feb 2021 08:30:58 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:22404) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lBdxn-0002zY-Ap for qemu-devel@nongnu.org; Mon, 15 Feb 2021 08:30:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613395854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nlSGHahkF324mbGBRljSfqPtcA3z8AW+WQJIMEgH4Ag=; b=ckMhyP5eyPkeN+DG7dxkpml7E93fAdfUidLNeQtMpY0/4WzrDKkbfSyKEh02qOcoK3eu7N Tg+T3Qe8COP37jBpv/e4rXq8tDX8EnCzNh+R7whEcFz1e+BSY/64RabGf/rkQkZtI/LLoX wHrjmqCA9CvI+8N2BzlyuBGIrAbNsAo= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-107-r-WxCRf7NUudpKWwiFcLgw-1; Mon, 15 Feb 2021 08:30:50 -0500 X-MC-Unique: r-WxCRf7NUudpKWwiFcLgw-1 Received: by mail-ed1-f71.google.com with SMTP id x18so2754716edq.19 for ; Mon, 15 Feb 2021 05:30:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nlSGHahkF324mbGBRljSfqPtcA3z8AW+WQJIMEgH4Ag=; b=VFkceC+7//XmA2iya5X/HVGq0BHvws59ZZVc9CAcHho8wJJDjPllFUGkfosxFCysfV igiygPVYzlSygBIIYsjCTH+hd5s9BBDoSFFz3ryyBDjRIxHLnY2ul2FeguGQoc7XhoaM jg/k+L84ND+iFsTW2WTSoGNfdhIa03Jc68KRjJELlYG9EVvcfwOt2ty2RcHbSFTcFG4W tPpfMMGR326Y2uBvOJ962Teafv7+3t7Hw8dYtVVY5BhcwyA2jbt17b0JyGNzhbvRBA10 wnZgV9NtrET26hX6hRmdK1fy2nd8dv+v37tcXtDK68mWJmMXu/CrbdH2RmW6gWhSrg8/ 7w1g== X-Gm-Message-State: AOAM530QWA+Iifv1IF53wgpqCPrG5QfzvQCySkIbVNbsRKi+bd6TiC5c fuJeUxnpWI20+nhssNcTTPQsb9uzJc4RTAmdgt0bZTN8kU2KwfTqM2pSf5hnRxvn9vt6fOOPE1q Xlrsf1qJwivrgn4rl8dR7Cbjvr5mTRiJgkfcjnPFhZrxzo4cXUvsmpE4WvbIrK/ttjUk= X-Received: by 2002:a17:906:af86:: with SMTP id mj6mr15733322ejb.509.1613395849262; Mon, 15 Feb 2021 05:30:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJzrltTlDsDHkciYeO1meKyp3mks+PY7vNNxaNjGroJoQF2+AQZLovr2319DSbbsN05zaL+slA== X-Received: by 2002:a17:906:af86:: with SMTP id mj6mr15733291ejb.509.1613395849008; Mon, 15 Feb 2021 05:30:49 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id e18sm649915eji.111.2021.02.15.05.30.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Feb 2021 05:30:48 -0800 (PST) Subject: Re: [RFC v18 08/15] i386: split smm helper (softmmu) To: Claudio Fontana , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20210212123622.15834-1-cfontana@suse.de> <20210212123622.15834-9-cfontana@suse.de> <87y2fptss2.fsf@linaro.org> <2a001d15-9b17-d356-aa2b-578f58fe63c4@suse.de> From: Paolo Bonzini Message-ID: <0cc5d1ab-088f-1b49-23cd-ecb3703329f0@redhat.com> Date: Mon, 15 Feb 2021 14:30:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <2a001d15-9b17-d356-aa2b-578f58fe63c4@suse.de> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Peter Maydell , Thomas Huth , Eduardo Habkost , Richard Henderson , qemu-devel@nongnu.org, Roman Bolshakov , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 15/02/21 13:59, Claudio Fontana wrote: > Yes. The difference between before the patch and after the patch > is that before we were still going through all the code in tcg_gen_callN, > via the call to gen_helper_rsm macro, only to call finally an empty function for CONFIG_USER_ONLY (helper_rsm() {}), > > while now we do not generate anything, we do not call the gen_helper_rsm macro at all, so we don't go through tcg_gen_callN. > Can we even have an abort() for such cases? Paolo