From: Paolo Bonzini <pbonzini@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>, Peng Hao <peng.hao2@zte.com.cn>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, rkrcmar@redhat.com,
mst@redhat.com, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH V6 1/5] target/i386 : add coalesced pio support
Date: Wed, 17 Oct 2018 19:05:12 +0200 [thread overview]
Message-ID: <0ced3ef9-f58e-18dd-0959-c69b96d27c4a@redhat.com> (raw)
In-Reply-To: <87woqgr4wp.fsf@vitty.brq.redhat.com>
On 17/10/2018 17:04, Vitaly Kuznetsov wrote:
>> + union {
>> + __u32 pad;
>> + __u32 pio;
>> + };
>> };
> I was just passing by, but what's the point in keeping 'pad'?
>
Backwards compatibility. QEMU does have a couple instances of "x.pad =
0", so...
Paolo
next prev parent reply other threads:[~2018-10-17 17:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 16:52 [Qemu-devel] [PATCH 0/5] target/i386: introduce coalesced pio Peng Hao
2018-10-17 16:52 ` [Qemu-devel] [PATCH V6 1/5] target/i386 : add coalesced pio support Peng Hao
2018-10-17 15:04 ` Vitaly Kuznetsov
2018-10-17 17:05 ` Paolo Bonzini [this message]
2018-10-17 16:52 ` [Qemu-devel] [PATCH V6 2/5] target-i386 : add coalesced_pio API Peng Hao
2018-10-17 16:52 ` [Qemu-devel] [PATCH V6 3/5] target-i386: add rtc 0x70 port as coalesced_pio Peng Hao
2018-10-17 10:31 ` Paolo Bonzini
2018-10-18 8:03 ` peng.hao2
2018-10-18 10:13 ` Paolo Bonzini
2018-10-18 10:43 ` peng.hao2
2018-10-17 16:52 ` [Qemu-devel] [PATCH V6 4/5] target-i386: add i440fx 0xcf8 " Peng Hao
2018-10-17 16:52 ` [Qemu-devel] [PATCH V6 5/5] target-i386: add q35 " Peng Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ced3ef9-f58e-18dd-0959-c69b96d27c4a@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=peng.hao2@zte.com.cn \
--cc=qemu-devel@nongnu.org \
--cc=rkrcmar@redhat.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).