* [Qemu-devel] [PATCH] hw: edu: set category of the edu device
@ 2019-01-24 14:46 kumar sourav
2019-01-24 14:49 ` Thomas Huth
2019-01-30 9:16 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: kumar sourav @ 2019-01-24 14:46 UTC (permalink / raw)
To: qemu-trivial; +Cc: jslaby, qemu-devel, thuth
Sets the category of edu device as DEVICE_CATEGORY_MISC.
Devices should be assigned to one of DEVICE_CATEGORY_XXXX.
Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
---
hw/misc/edu.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/misc/edu.c b/hw/misc/edu.c
index ceaf688bfb..91af452c9e 100644
--- a/hw/misc/edu.c
+++ b/hw/misc/edu.c
@@ -399,6 +399,7 @@ static void edu_instance_init(Object *obj)
static void edu_class_init(ObjectClass *class, void *data)
{
+ DeviceClass *dc = DEVICE_CLASS(class);
PCIDeviceClass *k = PCI_DEVICE_CLASS(class);
k->realize = pci_edu_realize;
@@ -407,6 +408,7 @@ static void edu_class_init(ObjectClass *class, void *data)
k->device_id = 0x11e8;
k->revision = 0x10;
k->class_id = PCI_CLASS_OTHERS;
+ set_bit(DEVICE_CATEGORY_MISC, dc->categories);
}
static void pci_edu_register_types(void)
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] hw: edu: set category of the edu device
2019-01-24 14:46 [Qemu-devel] [PATCH] hw: edu: set category of the edu device kumar sourav
@ 2019-01-24 14:49 ` Thomas Huth
2019-01-30 9:16 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2019-01-24 14:49 UTC (permalink / raw)
To: kumar sourav, qemu-trivial; +Cc: jslaby, qemu-devel
On 2019-01-24 15:46, kumar sourav wrote:
> Sets the category of edu device as DEVICE_CATEGORY_MISC.
> Devices should be assigned to one of DEVICE_CATEGORY_XXXX.
>
> Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
> ---
> hw/misc/edu.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/misc/edu.c b/hw/misc/edu.c
> index ceaf688bfb..91af452c9e 100644
> --- a/hw/misc/edu.c
> +++ b/hw/misc/edu.c
> @@ -399,6 +399,7 @@ static void edu_instance_init(Object *obj)
>
> static void edu_class_init(ObjectClass *class, void *data)
> {
> + DeviceClass *dc = DEVICE_CLASS(class);
> PCIDeviceClass *k = PCI_DEVICE_CLASS(class);
>
> k->realize = pci_edu_realize;
> @@ -407,6 +408,7 @@ static void edu_class_init(ObjectClass *class, void *data)
> k->device_id = 0x11e8;
> k->revision = 0x10;
> k->class_id = PCI_CLASS_OTHERS;
> + set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> }
>
> static void pci_edu_register_types(void)
>
Looks fine.
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw: edu: set category of the edu device
2019-01-24 14:46 [Qemu-devel] [PATCH] hw: edu: set category of the edu device kumar sourav
2019-01-24 14:49 ` Thomas Huth
@ 2019-01-30 9:16 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2019-01-30 9:16 UTC (permalink / raw)
To: kumar sourav, qemu-trivial; +Cc: thuth, jslaby, qemu-devel
On 24/01/2019 15:46, kumar sourav wrote:
> Sets the category of edu device as DEVICE_CATEGORY_MISC.
> Devices should be assigned to one of DEVICE_CATEGORY_XXXX.
>
> Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
> ---
> hw/misc/edu.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/misc/edu.c b/hw/misc/edu.c
> index ceaf688bfb..91af452c9e 100644
> --- a/hw/misc/edu.c
> +++ b/hw/misc/edu.c
> @@ -399,6 +399,7 @@ static void edu_instance_init(Object *obj)
>
> static void edu_class_init(ObjectClass *class, void *data)
> {
> + DeviceClass *dc = DEVICE_CLASS(class);
> PCIDeviceClass *k = PCI_DEVICE_CLASS(class);
>
> k->realize = pci_edu_realize;
> @@ -407,6 +408,7 @@ static void edu_class_init(ObjectClass *class, void *data)
> k->device_id = 0x11e8;
> k->revision = 0x10;
> k->class_id = PCI_CLASS_OTHERS;
> + set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> }
>
> static void pci_edu_register_types(void)
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-30 9:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-24 14:46 [Qemu-devel] [PATCH] hw: edu: set category of the edu device kumar sourav
2019-01-24 14:49 ` Thomas Huth
2019-01-30 9:16 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).